Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing lowering for calls #164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implementing lowering for calls #164

wants to merge 1 commit into from

Conversation

parsifal-47
Copy link
Contributor

  • removing the assertion which disallowed tensors of 1x1, I do not see why it was set, it seems that removing does not produce an error, let me know what you think. Thank you!

@parsifal-47 parsifal-47 mentioned this pull request Aug 15, 2024
Open
@parsifal-47
Copy link
Contributor Author

@nhat-nguyen please take a look when you have a chance, thank you!

@nhat-nguyen
Copy link
Collaborator

sure, give me some time to double check that removing the assert is ok

@parsifal-47
Copy link
Contributor Author

sure, give me some time to double check that removing the assert is ok

great, no rush, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parsifal-47 @nhat-nguyen