Add documentation on how to integrate triton-shared with existing triton compilers
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-vanderzee-microsoft
requested changes
Jul 15, 2024
There was a problem hiding this comment.
-
The instructions are clear and well written. Any adjustments are mostly semantics, and not important.
-
I suggest removing the
tritonsubmoduleupdate from this change for regression reasons. Aside from this, I approve this change.
Warning
I have not run through the instructions from scratch to validate integration; however, I can do so if necessary. As such, my approval is only for the way in which it is written.
There was a problem hiding this comment.
Potentially should be separated from this change.
manbearian
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
triton-sharedwith existing triton compilers (underINTEGRATIONS.md)INTERNALS.md