Refactor nested target-typed new in ObjectModelConverters #7087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement Simon's suggestion to improve readability: - Extract repeated LinePosition to a variable - Use named parameter 'lineSpan' for clarity - Eliminate duplicate LinePosition instantiation Related to #7050 Co-authored-by: nohwnd <[email protected]>
Copilot
AI
changed the title
[WIP] Refactor target-typed new usage for improved readability
Refactor nested target-typed new in ObjectModelConverters
Dec 9, 2025
Youssef1313
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same LinePosition when constructing line span that points to single line.
Related #7050