Skip to content

Report target framework rather than runtime framework #7081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nohwnd wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Report target framework rather than runtime framework #7081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,10 @@ public async Task<bool> IsCompatibleProtocolAsync(string hostType)
{
{ HandshakeMessagePropertyNames.PID, _environment.ProcessId.ToString(CultureInfo.InvariantCulture) },
{ HandshakeMessagePropertyNames.Architecture, RuntimeInformation.ProcessArchitecture.ToString() },
{ HandshakeMessagePropertyNames.Framework, RuntimeInformation.FrameworkDescription },
// Reports the information from the assembly attribute if available. This shows what the application targets rather than what it is running on. So user sees net472 if they run net472 app, but the system has net48 installed.
// Similarly for .NET it reports the version they target, rather than the version of the runtime they will end up using, e.g. when they roll forward from net9 to net10, they will see net9.
// Runtime information has some usability but is probably better suited for diagnostic information.
{ HandshakeMessagePropertyNames.Framework, Assembly.GetEntryAssembly()?.GetCustomAttribute<TargetFrameworkAttribute>()?.FrameworkDisplayName ?? RuntimeInformation.FrameworkDescription },
{ HandshakeMessagePropertyNames.OS, RuntimeInformation.OSDescription },
{ HandshakeMessagePropertyNames.SupportedProtocolVersions, supportedProtocolVersions },
{ HandshakeMessagePropertyNames.HostType, hostType },
Expand Down
Loading