You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Can you please explain here, or in the linked issue what is the problem that is solved, and why it is not correct to consider space as delimiter? I am sure someone will run into this in the future, and it is complicated to figure out what is the intention of this change from the code alone.
In command line, when you type --option value, they end up as two separate arguments (i.e, you have args array of two elements, --option and value. You don't end up with --option value as a single arg. You can end up with --option value as single arg if you enclose it in double quotes in command-line, and in which case I don't think splitting by the space is correct here.
The rest of the logic, as indicated in the linked issue, is already also broken as it can swallow some values. Revising the whole logic, lots of things don't make sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not correct to consider space as an option-value delimiter.
Fixes #7039
The implementation was previously buggy, and unnecessarily more complicated.
This simplifies the implementation, and makes it more correct.