Skip to content

Fix MSTEST0057 false positive on static constructors #6937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Youssef1313 merged 3 commits into from
Nov 14, 2025
Merged

Fix MSTEST0057 false positive on static constructors #6937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
847d224
Initial plan
Copilot Nov 12, 2025
03a2706
Fix MSTEST0057 to skip static constructors
Copilot Nov 12, 2025
3829c12
Only check instance constructors
Youssef1313 Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...Analyzers/MSTest.Analyzers/TestMethodAttributeShouldPropagateSourceInformationAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private static void AnalyzeSymbol(SymbolAnalysisContext context, INamedTypeSymbo
return;
}

foreach (IMethodSymbol constructor in namedTypeSymbol.Constructors)
foreach (IMethodSymbol constructor in namedTypeSymbol.InstanceConstructors)
{
// Check if constructor has CallerFilePath and CallerLineNumber parameters
bool hasCallerFilePath = false;
Expand Down
84 changes: 84 additions & 0 deletions ...t.Analyzers.UnitTests/TestMethodAttributeShouldPropagateSourceInformationAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,4 +481,88 @@ public DerivedTestMethodAttribute([CallerFilePath] string callerFilePath = "", [

await VerifyCS.VerifyCodeFixAsync(code, code);
}

[TestMethod]
public async Task WhenDerivedTestMethodAttributeWithStaticConstructor_NoDiagnostic()
{
string code = """
using Microsoft.VisualStudio.TestTools.UnitTesting;
using System.Runtime.CompilerServices;

public class MyTestMethodAttribute : TestMethodAttribute
{
static MyTestMethodAttribute()
{
}

public MyTestMethodAttribute([CallerFilePath] string callerFilePath = "", [CallerLineNumber] int callerLineNumber = -1)
: base(callerFilePath, callerLineNumber)
{
}
}
""";

await VerifyCS.VerifyCodeFixAsync(code, code);
}

[TestMethod]
public async Task WhenDerivedTestMethodAttributeWithStaticField_NoDiagnostic()
{
string code = """
using Microsoft.VisualStudio.TestTools.UnitTesting;
using System;
using System.Runtime.CompilerServices;

public class MyTestMethodAttribute : TestMethodAttribute
{
static DateTimeOffset s_field = new();

public MyTestMethodAttribute([CallerFilePath] string callerFilePath = "", [CallerLineNumber] int callerLineNumber = -1)
: base(callerFilePath, callerLineNumber)
{
}
}
""";

await VerifyCS.VerifyCodeFixAsync(code, code);
}

[TestMethod]
public async Task WhenDerivedTestMethodAttributeWithStaticConstructorAndMissingCallerInfo_Diagnostic()
{
string code = """
using Microsoft.VisualStudio.TestTools.UnitTesting;

public class SomeTestMethodAttribute : TestMethodAttribute
{
static SomeTestMethodAttribute()
{
}

public [|SomeTestMethodAttribute|]()
: base()
{
}
}
""";

string fixedCode = """
using System.Runtime.CompilerServices;
using Microsoft.VisualStudio.TestTools.UnitTesting;

public class SomeTestMethodAttribute : TestMethodAttribute
{
static SomeTestMethodAttribute()
{
}

public SomeTestMethodAttribute([CallerFilePath] string callerFilePath = "", [CallerLineNumber] int callerLineNumber = -1)
: base(callerFilePath, callerLineNumber)
{
}
}
""";

await VerifyCS.VerifyCodeFixAsync(code, fixedCode);
}
}
Loading