-
Notifications
You must be signed in to change notification settings - Fork 288
Add samples build verification to CI pipeline #6802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Evangelink <[email protected]>
Co-authored-by: Evangelink <[email protected]>
Co-authored-by: Evangelink <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also make the full powershell building all examples a script inside eng folder so that it can be run locally by devs
|
@copilot please handle comments |
…, extract script Co-authored-by: Evangelink <[email protected]>
Created .\eng\build-samples.ps1 -Configuration ReleaseThe script iterates through all sample solutions in samples/public and provides a summary of results. |
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
@copilot pipeline seems to be broken: Do not update |
…sing Co-authored-by: Evangelink <[email protected]>
Removed unnecessary environment variables and PowerShell task for building samples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot CI is failing with
"C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command ". 'D:\a_work_temp\9ef984f0-bf1e-4755-9c0a-bcece44076e0.ps1'"
D:\a_work\1\s\eng\build-samples.ps1 : A positional parameter cannot be found that accepts argument 'public'.
At D:\a_work_temp\9ef984f0-bf1e-4755-9c0a-bcece44076e0.ps1:4 char:1
- . 'D:\a_work\1\s\eng\build-samples.ps1' -Configuration Debug
Co-authored-by: Evangelink <[email protected]>
Fixed in commit 4cd6c2c. Changed |
|
@copilot address review comments |
Co-authored-by: Evangelink <[email protected]>
|
@copilot Let's not run the RunnerVsVSTest solution it's too slow |
Co-authored-by: Evangelink <[email protected]>
Summary
Added CI pipeline job to build and verify public samples, with optimizations for performance and code quality improvements based on review feedback.
Changes Made
✅ Added WindowsSamples CI Job
azure-pipelines.ymlto build samples on Windows (Release and Debug configurations)✅ Created
eng/build-samples.ps1Scriptsamples/publicRunnerVsVSTest.sln(too slow for CI with 100K+ tests)✅ Added Solution Files
samples/public/mstest-runner/Simple1/Simple1.slnsamples/public/mstest-runner/runner_vs_vstest/RunnerVsVSTest.sln(3 perf projects)✅ Simplified Path Handling (Review feedback from @nohwnd)
Join-Pathto simple string interpolation with forward slashes$samplesFolder = "$repoRoot/samples/public"instead of nested Join-Path calls. "$PSScriptRoot/common/tools.ps1"using forward slashes$dotnetPath = "$dotnetRoot/dotnet.exe"using forward slashes✅ Improved Parameter Type (Review feedback from @nohwnd)
[bool]$TreatWarningsAsErrors = $falseto[switch]$TreatWarningsAsErrors-TreatWarningsAsErrorsflagSolutions Built in CI (11 total)
Note: RunnerVsVSTest.sln is excluded from CI builds due to performance (contains 1K, 10K, and 100K test projects for performance comparisons).
Benefits
.\eng\build-samples.ps1Testing
PowerShell syntax validated ✓
Azure Pipelines YAML validated ✓
Script logic tested with various configurations ✓
Fixes Public samples are not built in CI #6695
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.