Skip to content

Conversation

@singhsarab
Copy link
Contributor

Make Description, CssIteration, WorkItem, CssProjectStructure available in properties in the TestCase object.
Fixes : #529

{
var attribute = GetCustomAttributes(attributeProvider, type, true);

if (attribute == null || attribute.Length != 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we have multiple workitem attributes? Do we want to silently ignore/not fill them in property bag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Then, we'd ideally want to make workitem property an array of workitems.

@singhsarab singhsarab merged commit 688c6ca into microsoft:master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants