Skip to content

Remove redundant explicit override of NuGet.Packaging and MessagePack #4981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Youssef1313 merged 5 commits into from
Feb 12, 2025
Merged

Remove redundant explicit override of NuGet.Packaging and MessagePack #4981

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9dd902c
Remove redundant explicit override of NuGet.Packaging
Youssef1313 Feb 12, 2025
c43970d
Remove redundant explicit override of MessagePack
Youssef1313 Feb 12, 2025
6d2e918
Merge branch 'main' into remove-redundant-packages
Youssef1313 Feb 12, 2025
dd68ddd
Merge branch 'main' into remove-redundant-packages
Youssef1313 Feb 12, 2025
3be0558
Apply suggestions from code review
Evangelink Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,24 +59,22 @@
<PackageVersion Include="Codecov" Version="1.12.3" />
<PackageVersion Include="FluentAssertions" Version="6.12.0" />
<PackageVersion Include="FSharp.Core" Version="8.0.200" />
<!-- CVE-2024-48924 / Transitive deps of StreamJsonRpc -->
<PackageVersion Include="MessagePack" Version="2.5.187" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Analyzer.Testing" Version="$(MicrosoftCodeAnalysisAnalyzerTestingVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.CodeFix.Testing" Version="$(MicrosoftCodeAnalysisAnalyzerTestingVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.CodeRefactoring.Testing" Version="$(MicrosoftCodeAnalysisAnalyzerTestingVersion)" />
<PackageVersion Include="Microsoft.Extensions.FileSystemGlobbing" Version="9.0.1" />
<PackageVersion Include="Microsoft.TestPlatform" Version="$(MicrosoftNETTestSdkVersion)" />
<PackageVersion Include="Microsoft.Win32.Registry" Version="5.0.0" />

<!-- Pinned to 4.18.4 for security -->
Comment thread
Evangelink marked this conversation as resolved.
<PackageVersion Include="Moq" Version="4.18.4" />

<PackageVersion Include="MSBuild.StructuredLogger" Version="2.2.386" />
Comment thread
Evangelink marked this conversation as resolved.
<PackageVersion Include="MSTest.Analyzers" Version="$(MSTestVersion)" />
<PackageVersion Include="MSTest.TestAdapter" Version="$(MSTestVersion)" />
<PackageVersion Include="MSTest.TestFramework" Version="$(MSTestVersion)" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
<!-- CVE-2024-0057 / Transitive deps of code analysis testing packages -->
<PackageVersion Include="NuGet.Packaging" Version="6.12.1" />
<PackageVersion Include="NuGet.Protocol" Version="6.12.1" />

<PackageVersion Include="Polly" Version="8.5.0" />
<PackageVersion Include="Polly.Contrib.WaitAndRetry" Version="1.1.1" />
<PackageVersion Include="StreamJsonRpc" Version="2.20.20" />
Expand Down
3 changes: 0 additions & 3 deletions test/UnitTests/MSTest.Analyzers.UnitTests/MSTest.Analyzers.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@

<!-- Deps of MSTest.TestAdapter -->
<PackageReference Include="Microsoft.TestPlatform.AdapterUtilities" />

<!-- CVE-2024-0057 / Transitive deps of code analysis testing packages -->
<PackageReference Include="NuGet.Packaging" />
</ItemGroup>

<ItemGroup>
Expand Down