Define MSTest to support managed sources only#399
Closed
mayankbansal018 wants to merge 32 commits intomicrosoft:masterfrom
mayankbansal018:mstestcategory
Closed
Define MSTest to support managed sources only#399mayankbansal018 wants to merge 32 commits intomicrosoft:masterfrom mayankbansal018:mstestcategory
mayankbansal018 wants to merge 32 commits intomicrosoft:masterfrom
mayankbansal018:mstestcategory
Conversation
Contributor
Author
|
@dotnet-bot test this please |
Member
|
Make sure you validate end to end flow before pushing this in. |
abhishkk
approved these changes
Apr 10, 2018
smadala
approved these changes
Apr 11, 2018
| [FileExtension(".appx")] | ||
| [FileExtension(".dll")] | ||
| [FileExtension(".exe")] | ||
| [Category("managed")] |
Contributor
There was a problem hiding this comment.
A comment will be helpful.
Contributor
Author
|
@dotnet-bot test this please |
Contributor
Author
|
@dotnet-bot test this please |
1 similar comment
Contributor
Author
|
@dotnet-bot test this please |
Contributor
Author
|
@dotnet-bot test this please |
jayaranigarg
approved these changes
Apr 23, 2018
|
|
||
| Utilities.setMachineAffinity(newJob, 'Windows_NT', 'latest-or-auto-dev15-0') | ||
| // Move to latest VS(15.6) machines | ||
| Utilities.setMachineAffinity(newJob, 'Windows_NT', 'latest-or-auto-dev15-0') |
Member
There was a problem hiding this comment.
This is same string only. We didn't update it to point to 15.6 machines?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following RFC: https://github.com/Microsoft/vstest-docs/blob/master/RFCs/0020-Improving-Logic-To-Pass-Sources-To-Adapters.md