-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stdout/stderr properties to TestNode #3225
Conversation
I'm not sure how this is possible for an adapter without:
I was wondering if make more sense have something more high level and less "low level" like notes-info/notes-error/notes-warning (naming TBD) cc: @Evangelink |
I'd be fine renaming it to If more levels are needed, or if the test should have a message stream we could consider that too. For instance:
As for how this is generated it should be up to the framework to decide. If it only wants to support an internal |
I think the point of @MarcoRossignoli is more to question having some "output" related to a "test node". You are taking a specific use-case and making it a component of the protocol that is supposed to represent a functional abstraction. I think it's better to think that a node can have messages attached (whether this is an output or something else is an implementation detail). |
If we rename @Evangelink do you have a preference of which of the two styles would be better. Whether |
Is this problematic? You have a point that we do need different "levels" and that maybe logging is indeed more generic. |
Make use of client/log to log stdout/stderr messages, but allow these to specify the runId/nodeUid properties to associate the logged message to a TestNode in a specific discovery/run request.
After an offline discussion, I updated the spec to be based on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MarcoRossignoli @nohwnd @jakubch1 please review too
Add stdout/stderr properties for the TestNode to the spec.