Document IDataConsumer UID filtering - #10740
Merged
Amaury Levé (Evangelink) merged 1 commit intoAug 25, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 469109f6-5c6d-4ebb-af75-24785643dc56
Amaury Levé (Evangelink)
added
the
state/needs-review
Amaury Levé (Evangelink)
enabled auto-merge (squash)
August 25, 2026 15:30
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Note
🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
Review Summary
This is a documentation-only change adding XML doc <remarks> to IDataConsumer and IMessageBus.PublishAsync to document the same-UID skip behavior.
| Dimension | Verdict |
|---|---|
| Accuracy | ✅ Verified — AsyncConsumerDataProcessor (line 90) and BlockingConsumerDataProcessor (line 55) both check dataProducer.Uid == DataConsumer.Uid and skip dispatch when they match. |
| Clarity | ✅ Clear and concise |
| Consistency | ✅ Matches existing XML doc style in the codebase |
| Completeness | ✅ Both the consumer interface and the publish method are annotated |
| Public API surface | ✅ No new public API — doc comments only |
No issues found. The documented behavior accurately reflects the implementation.
Contributor
There was a problem hiding this comment.
Pull request overview
Documents message-bus UID filtering to clarify why consumers do not receive self-produced data.
Changes:
- Documents same-UID filtering on
IMessageBus.PublishAsync. - Advises
IDataConsumerimplementations to process self-produced data directly.
Show a summary per file
| File | Description |
|---|---|
IMessageBus.cs |
Documents publish-time UID filtering. |
IDataConsumer.cs |
Explains UID requirements and self-processing guidance. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
Petr Pokorny (0101)
approved these changes
Aug 25, 2026
Amaury Levé (Evangelink)
deleted the
dev/amauryleve/document-idataconsumer-uid-rules
branch
August 25, 2026 17:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies that the Microsoft.Testing.Platform message bus does not dispatch data to an
IDataConsumerwhen the producer and consumer share the sameIExtension.Uid.The API documentation now explains that producer and consumer registrations communicating through the message bus need distinct UIDs, while self-produced data should be processed directly.
Fixes #4588