Skip to content

Deduplicate published-results parsing in Azure DevOps client - #10735

Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
dev/amauryleve/deduplicate-results-parsing
Aug 25, 2026
Merged

Deduplicate published-results parsing in Azure DevOps client#10735
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
dev/amauryleve/deduplicate-results-parsing

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Publishing and updating Azure DevOps test results duplicated the same response parsing and non-retry exception handling, making the two paths easier to drift apart.

Extract the shared behavior into TryReadAndParsePublishedResultsAsync and use it from both paths while preserving their distinct result validation and user-cancellation semantics.

Tests: AzureDevOpsLivePublishingTests (128 passed).

Fixes #10732

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: d952f592-db2e-4a30-b46d-312c105eca7c
Copilot AI balanced review requested due to automatic review settings August 25, 2026 15:08
@Evangelink Amaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Aug 25, 2026
@Evangelink
Amaury Levé (Evangelink) enabled auto-merge (squash) August 25, 2026 15:14

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 22/22 dimensions clean — no findings.

Small, well-scoped refactoring: the duplicated try/catch/parse-response blocks in PublishTestResultsWithSubResultsAsync and UpdateTestResultsWithSubResultsAsync are consolidated into the private TryReadAndParsePublishedResultsAsync helper. Parameter forwarding (readTimeoutToken, userCancellationToken, validateAutomatedTestName) is correct, trimming/AOT suppression attributes are correctly carried to the helper, and no behavioral change is introduced. No test changes needed for a purely mechanical extraction.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Deduplicates Azure DevOps response parsing while preserving validation and cancellation behavior.

Changes:

  • Extracts shared parsing and exception handling into one helper.
  • Reuses it for publish and update paths.
Show a summary per file
File Description
AzureDevOpsTestResultsClient.cs Centralizes published-result response handling.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@Evangelink
Amaury Levé (Evangelink) merged commit 4c5f67e into main Aug 25, 2026
29 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/deduplicate-results-parsing branch August 25, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-review Awaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[code-simplifier] Deduplicate published-results parsing in AzureDevOpsTestResultsClient

3 participants