Declare PlatformServices as non-packable - #10728
Conversation
Document that MSTest.TestAdapter bundles the assembly and prevent standalone package generation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05d06302-12f7-4db0-a3a7-8923510820f9
Amaury Levé (Evangelink)
added
the
state/needs-review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Warning
Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.
What happened
The threat detection results could not be parsed.
Review the workflow run logs for details.
Note
🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
Review Summary
Verdict: ✅ All clear — no issues found.
This is a small, well-scoped change that correctly marks MSTestAdapter.PlatformServices as IsPackable=false. The project's output DLL is bundled into MSTest.TestAdapter's buildTransitive/ folder (confirmed via the .targets files referencing MSTestAdapter.PlatformServices.dll), so it was never intended to produce its own NuGet package.
Dimension Assessment
| # | Dimension | Finding |
|---|---|---|
| 1–4 | Algorithmic / Thread Safety / Perf / Error Handling | N/A — no runtime code change |
| 5 | Packaging & NuGet Metadata | ✅ Setting IsPackable=false exempts the project from the _ValidatePackageMetadata target in Directory.Build.targets, which is correct since this assembly ships inside another package. No PackageDescription or PACKAGE.md is needed. |
| 6 | MSBuild Correctness | ✅ Property is placed in the main PropertyGroup alongside other project metadata. No ordering issue. |
| 7 | Cross-TFM | N/A |
| 8 | Public API Surface | N/A |
| 9–22 | Remaining dimensions | N/A — change is purely declarative build metadata |
Comment quality
The inline XML comment clearly explains why the project isn't packable, aiding future maintainers. No further action needed.
Generated by Expert Code Review (on PR ready) for #10728 · auto · 65.2 AIC · ⌖ 0.834 AIC · ⊞ 10.4K
There was a problem hiding this comment.
Pull request overview
Explicitly marks the embedded PlatformServices project as non-packable.
Changes:
- Sets
IsPackabletofalse. - Documents that the assembly is bundled into
MSTest.TestAdapter.
Show a summary per file
| File | Description |
|---|---|
src/Adapter/MSTestAdapter.PlatformServices/MSTestAdapter.PlatformServices.csproj |
Declares and documents non-packable status. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
MSTestAdapter.PlatformServicesis bundled intoMSTest.TestAdapterrather than published as a standalone package, but its project relied on the SDK's implicitIsPackable=truedefault.Explicitly set
IsPackable=falseand document the embedding relationship so the project's packaging intent is clear and direct pack invocations do not attempt to produce a package.Fixes #10709