Fix apphost DOTNET_ROOT path assertion - #10626
Merged
Amaury Levé (Evangelink) merged 1 commit intoAug 24, 2026
Merged
Conversation
Compare Windows path values without drive-letter casing sensitivity. 🤖
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the apphost acceptance test to tolerate Windows drive-letter casing differences.
Changes:
- Extracts
DOTNET_ROOT_<ARCH>from test output. - Compares paths case-insensitively on Windows.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jakub Jareš (nohwnd)
marked this pull request as ready for review
August 19, 2026 16:21
Amaury Levé (Evangelink)
approved these changes
Aug 24, 2026
Amaury Levé (Evangelink)
left a comment
Amaury Levé (Evangelink)
left a comment
Member
There was a problem hiding this comment.
Approving assymiung there was a scenario that triggered the issue and fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare the derived Windows path without drive-letter case sensitivity.
DOTNET_HOST_PATHcan use a lowercase drive letter whileRootFinderreturns uppercase, even though both resolve to the same directory.Verified: the affected
net11.0|x64acceptance test passes locally.🤖