Skip to content

[docs] Document MTP server mode - #10499

Merged
Amaury Levé (Evangelink) merged 3 commits into
mainfrom
dev/amauryleve/update-server-mode-glossary
Aug 7, 2026
Merged

[docs] Document MTP server mode#10499
Amaury Levé (Evangelink) merged 3 commits into
mainfrom
dev/amauryleve/update-server-mode-glossary

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

  • define MTP Server Mode and link it to the JSON-RPC protocol
  • document the source-only Microsoft.Testing.Platform.ServerMode.Client.Sources package

Fixes #10496

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0aa497c8-0353-45a7-aef1-e989e06f5854
Copilot AI balanced review requested due to automatic review settings August 7, 2026 09:09

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Expert Review — docs/glossary.md

Documentation-only change adding two new glossary entries. Reviewed against all 22 dimensions; only documentation-relevant dimensions apply.

Verification summary

Check Result
Microsoft.Testing.Platform.ServerMode.Client.Sources project exists src/Platform/Microsoft.Testing.Platform.ServerMode.Client.Sources/ found
PR #10085 reference accurate ✅ Commit history confirms
#server-mode anchor target exists ✅ Line 458
#json-rpc-protocol anchor target exists ✅ Line 206
Alphabetical placement consistent with existing convention ✅ Follows existing Platform → Extensions grouping
Entry style matches surrounding entries

Dimension verdicts

# Dimension Verdict
1–10 Algorithmic Correctness through Security N/A (docs only)
11 Documentation & Comments ✅ Clean — entries are accurate, well-written, and follow existing glossary style
12 Naming & Readability ✅ Clean
13–22 Remaining dimensions N/A (docs only)

Overall: Clean. Both entries are factually accurate, correctly cross-referenced, and consistent with the glossary's existing style and ordering conventions. No issues found.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Documents Microsoft Testing Platform (MTP) “Server Mode” and adds a glossary entry for the source-only client package used to communicate with an MTP server via JSON-RPC.

Changes:

  • Added glossary entry for Microsoft.Testing.Platform.ServerMode.Client.Sources.
  • Defined “Server Mode” and linked it to the JSON-RPC protocol.
Show a summary per file
File Description
docs/glossary.md Adds “Server Mode” definition and documents the server-mode client sources package.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Lite

Comment thread docs/glossary.md
Comment thread docs/glossary.md Outdated
@Evangelink
Amaury Levé (Evangelink) enabled auto-merge (squash) August 7, 2026 09:53
@Evangelink Amaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Aug 7, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0aa497c8-0353-45a7-aef1-e989e06f5854
Copilot AI review requested due to automatic review settings August 7, 2026 09:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Suppressed comments (1)

docs/glossary.md:464

  • Keep the S entries alphabetical: SequenceOrder sorts before Server Mode, as required by the glossary-maintainer convention in .github/workflows/glossary-maintainer.md:183-186. Please move this new entry below SequenceOrder.
### Server Mode
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0aa497c8-0353-45a7-aef1-e989e06f5854
Copilot AI review requested due to automatic review settings August 7, 2026 10:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Suppressed comments (1)

docs/glossary.md:464

  • The PR description and linked issue identify the long-lived process as the defining characteristic of Server Mode, but this definition no longer states that the server persists across requests. Please make that lifecycle explicit so readers can distinguish Server Mode from a one-shot test-host invocation.
An MTP execution mode in which the test host process runs as a server and communicates with a client (such as an IDE, CLI, or CI tool) over the [JSON-RPC Protocol](#json-rpc-protocol). The client can initialize the server, request test discovery or execution, receive test updates, and stop the server when finished.
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@Evangelink
Amaury Levé (Evangelink) merged commit 54b7606 into main Aug 7, 2026
13 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/update-server-mode-glossary branch August 7, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-review Awaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] Update glossary - daily scan

3 participants