Work around check-spelling v0.0.26 bug - #20545
Open
Josh Soref (jsoref) wants to merge 1 commit into
Open
Conversation
In v0.0.26, check_extra_dictionaries isn't honored from config.json for pull requests Leave `cspell` with the value from v0.0.26, and use `cspell1` for the active dictionaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
In v0.0.26, check_extra_dictionaries isn't honored from config.json for pull requests
Leave
cspellwith the value from v0.0.26, and usecspell1for the active dictionaries.References and Relevant Issues
Detailed Description of the Pull Request / Additional comments
check-spelling v0.0.26 has a minor bug where it doesn't honor check_extra_dictionaries from config.json in pull requests (it does for pushes). I missed it in testing (it's fixed in prerelease).
The workaround is to use a different alias in config.json for the check_extra_dictionaries and reserve
cspellfor the current version of check-spelling (currently v0.0.26). When the repository updates to the next version, that aliasing can be dropped (and at some point, once people are all relying on config.json, I'll probably upgrade the defaults, but until people are using a version of config.json that can tolerate such jitter, I don't want to do that...).Validation Steps Performed
PR Checklist