Fix visual artifacts when using QQ Wubi IME - #20542
Merged
Merged
Conversation
Leonard Hecker (lhecker)
marked this pull request as ready for review
August 13, 2026 14:06
Leonard Hecker (lhecker)
added
Product-Conhost
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
| const auto compositionRow = _compositionCache ? _compositionCache->absoluteOrigin.y : -1; | ||
| const auto& activeComposition = _pData->GetActiveComposition(); | ||
| auto& buffer = _pData->GetTextBuffer(); | ||
| auto& scratchRow = buffer.GetScratchpadRow(); |
Member
Author
There was a problem hiding this comment.
All changes in this file exist simply to make the code exception-safe (it wasn't before).
| const auto attr = _textAttributeFromAtom(atom); | ||
| activeCompositionRanges.emplace_back(totalLen, attr); | ||
| if (isActiveComposition) | ||
| { |
There was a problem hiding this comment.
how does this fix the issue? I'm being dense
Dustin L. Howett (DHowett)
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes MSFT-63412896
Validation Steps Performed
winget install Tencent.QQWubiwwwwwand backspacew