Bugfix: only round to the nearest cell for selection - #18486
Merged
Carlos Zamora (carlos-zamora) merged 2 commits intoJan 31, 2025
Conversation
Dustin L. Howett (DHowett)
requested changes
Jan 31, 2025
Dustin L. Howett (DHowett)
left a comment
Dustin L. Howett (DHowett)
left a comment
Member
There was a problem hiding this comment.
Do away with the GH# references - in a way, it's like saying "this is related to the selection changes". Well, every change here is related to selection ;)
microsoft-github-policy-service
Bot
added
the
Needs-Author-Feedback
Co-authored-by: Dustin L. Howett <duhowett@microsoft.com>
microsoft-github-policy-service
Bot
removed
the
Needs-Author-Feedback
Leonard Hecker (lhecker)
approved these changes
Jan 31, 2025
Dustin L. Howett (DHowett)
approved these changes
Jan 31, 2025
Carlos Zamora (carlos-zamora)
enabled auto-merge (squash)
January 31, 2025 22:08
Carlos Zamora (carlos-zamora)
deleted the
dev/cazamor/bugfix-selection-rounding
branch
January 31, 2025 22:30
This was referenced Feb 19, 2025
Dustin L. Howett (DHowett)
pushed a commit
that referenced
this pull request
Feb 26, 2025
…mode (#18602) Missed a few `_getTerminalPosition()` on the first run. Disabled rounding for pointer movements and mouse wheel events (which are used for hyperlink hover detection and vt mouse mode). The only time we round now is... - `SetEndSelectionPoint()` --> because we're updating a selection - `ControlCore->LeftClickOnTerminal()` --> where all paths are used for selection* *the only path that doesn't is `RepositionCursorWithMouse` being enabled, which also makes sense based on clicking around Notepad with a large font size. ## References and Relevant Issues Follow-up for #18486 Closes #18595 ## Validation Steps Performed In large font size, play around with midnight commander and hover over hyperlink edges.
Dustin L. Howett (DHowett)
pushed a commit
that referenced
this pull request
Feb 26, 2025
…mode (#18602) Missed a few `_getTerminalPosition()` on the first run. Disabled rounding for pointer movements and mouse wheel events (which are used for hyperlink hover detection and vt mouse mode). The only time we round now is... - `SetEndSelectionPoint()` --> because we're updating a selection - `ControlCore->LeftClickOnTerminal()` --> where all paths are used for selection* *the only path that doesn't is `RepositionCursorWithMouse` being enabled, which also makes sense based on clicking around Notepad with a large font size. ## References and Relevant Issues Follow-up for #18486 Closes #18595 ## Validation Steps Performed In large font size, play around with midnight commander and hover over hyperlink edges. (cherry picked from commit e5b972a) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgXgv1c Service-Version: 1.23
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes a bug where VT mouse mode would round to the nearest cell when clicking the mouse button.
The fix is to round to the nearest cell only when we're selecting text. The other scenarios affected are:
Really the most notable ones were the first two. So now, we use the position of the cell we clicked on. We only round for selection.
References and Relevant Issues
Follow-up to #18106
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Opened Midnight Commander in Ubuntu and clicked between the two panes.