Added CodeQL supression comment #18431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
reviewed
Jan 15, 2025
| @@ -115,7 +115,7 @@ void SaveConsoleSettingsIfNeeded(const HWND hwnd) | |||
| LoadStringW(ghInstance, IDS_LINKERROR, awchBuffer, ARRAYSIZE(awchBuffer)); | |||
| StringCchPrintf(szMessage, | |||
| ARRAYSIZE(szMessage), | |||
| awchBuffer, | |||
| awchBuffer, // CodeQL [SM01734] Pulled from a resource file and cannot be a string literal | |||
There was a problem hiding this comment.
wait, didn't you fix one of these already? Does CodeQL spit out a single error every time? Can it be made to report all of them instead so we can fix them all in one PR?
There was a problem hiding this comment.
@DHowett Yeah I didn't realize it wasn't one of the files under OSS that got fixed for 1.22. This is the last one we got with our set of 3 from a couple months ago. I don't expect any more of these
microsoft-github-policy-service
bot
added
Needs-Author-Feedback
carlos-zamora
approved these changes
Jan 15, 2025
DHowett
approved these changes
Jan 15, 2025
DHowett
pushed a commit
that referenced
this pull request
Jan 15, 2025
CodeQL is raising errors when building Visual Studio since they have a dependency on Windows Terminal for our integrated terminal. The issue raised by CodeQL refers to a non-constant string format, but in this case the string comes from a resource file and should be considered constant. (cherry picked from commit 25392ea) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgWYgYU Service-Version: 1.22
DHowett
pushed a commit
that referenced
this pull request
Jan 15, 2025
CodeQL is raising errors when building Visual Studio since they have a dependency on Windows Terminal for our integrated terminal. The issue raised by CodeQL refers to a non-constant string format, but in this case the string comes from a resource file and should be considered constant. (cherry picked from commit 25392ea) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgWYgYM Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
CodeQL is raising errors when building Visual Studio since we have a dependency on Windows Terminal for our integrated terminal. The issue raised by CodeQL refers to a non-constant string format, but in this case the string comes from a resource file and should be considered constant.
This PR adds an ignore comment for CodeQL
References and Relevant Issues
CodeQL error: https://liquid.microsoft.com/codeql/issues/95192647-5121-4d27-b873-63e63e825d72?copilot_promptid=E91B0CE9-0C1B-4AC2-8A46-33F49B67E058
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
PR Checklist