Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema description #18388

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Fix schema description #18388

merged 2 commits into from
Jan 28, 2025

Conversation

Tarang74
Copy link
Contributor

@Tarang74 Tarang74 commented Jan 3, 2025 •
edited
Loading

Summary of the Pull Request

Fixes typo in experimental.rightClickContextMenu property description. Description should say right-click pastes, rather than copies.

PR Checklist

  • Schema updated

DHowett
DHowett requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so funny enough, the default action for right-click is actually both of those things. it copies if there is a selection or pastes if there is not.

if you can think of a succinct way to cover both of those things, i'd love to approve it!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 6, 2025
@Tarang74
Copy link
Contributor Author

Tarang74 commented Jan 6, 2025 •
edited
Loading

interesting! i'll revise the description when i have time this week!

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jan 6, 2025
@Tarang74
Copy link
Contributor Author

Sorry for the delay, I hope this is clear!

@Tarang74 Tarang74 requested a review from DHowett January 28, 2025 14:10
DHowett
DHowett approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thank you!

@DHowett DHowett requested a review from carlos-zamora January 28, 2025 23:00
@DHowett DHowett merged commit 8a806e0 into microsoft:main Jan 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

Assignees
No one assigned
Labels
Needs-Attention The core contributors need to come back around and look at this ASAP.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tarang74 @DHowett