Align the OSS ConPTY API with Windows 11 24H2 #17704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Product-Conpty
DHowett
approved these changes
Aug 13, 2024
|
Tests are broken ;) |
DHowett
approved these changes
Aug 14, 2024
3 tasks
DHowett
pushed a commit
that referenced
this pull request
Aug 21, 2024
(cherry picked from commit 7fd9c5c) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgSGCkE Service-Version: 1.21
cristianadam
pushed a commit
to cristianadam/qt-creator
that referenced
this pull request
Jan 7, 2025
Windows 11 24H2 changed the underlying implementation and the "ClosePseudoConsole" code that we copied from the Terminal application didn't work as it did before. The new Terminal releases also removes the WaitForSingleObject call. See microsoft/terminal#17704 We cannot rely on the ConPty API since it doesn't send the "-- resizeQuirk" parameter to "conhost.exe", and the QTCREATORBUG-30007 would be resurrected. Fixes: QTCREATORBUG-32192 Change-Id: Ie21833a1eb21acd0ba21109f3dbc28595b0d94a4
qtprojectorg
pushed a commit
to qt-creator/qt-creator
that referenced
this pull request
Jan 7, 2025
Windows 11 24H2 changed the underlying implementation and the "ClosePseudoConsole" code that we copied from the Terminal application didn't work as it did before. The new Terminal releases also removes the WaitForSingleObject call. See microsoft/terminal#17704 We cannot rely on the ConPty API since it doesn't send the "-- resizeQuirk" parameter to "conhost.exe", and the QTCREATORBUG-30007 would be resurrected. Fixes: QTCREATORBUG-32192 Change-Id: Ie21833a1eb21acd0ba21109f3dbc28595b0d94a4 Reviewed-by: Marcus Tillmanns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
ClosePseudoConsoleTimeoutas waiting for conhostto exit is prone to deadlocks due to incorrect API usage.
Additionally, this publicly exposes
ReleasePseudoConsole.