Address feedback from #17510 #17645
Merged
Address feedback from #17510 #17645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
the
Area-CodeHealth
DHowett
reviewed
Aug 1, 2024
src/host/_stream.cpp
Outdated
| @@ -368,6 +372,7 @@ void WriteCharsVT(SCREEN_INFORMATION& screenInfo, const std::wstring_view& str) | |||
| { "\x1b[?1004h\x1b[?9001h" }, // RIS: Focus Event Mode + Win32 Input Mode | |||
| { "\033[?1004h" } // DECSET_FOCUS: Focus Event Mode | |||
There was a problem hiding this comment.
while you're here
Suggested change
| { "\033[?1004h" } // DECSET_FOCUS: Focus Event Mode | |
| { "\x1b[?1004h" } // DECSET_FOCUS: Focus Event Mode |
There was a problem hiding this comment.
Right, I can also fix the BEL vs ST thing too.
DHowett
approved these changes
Aug 1, 2024
lhecker
commented
Aug 1, 2024
| { | ||
| WriteUTF8("\x1b]0;"); | ||
| WriteUTF16StripControlChars(title); | ||
| WriteUTF8("\x1b\\"); |
This comment was marked as spam.
This comment was marked as spam.
|
@mominshaikhdevs Could you either explain why you keep linking #1765, or stop doing so? 2 words are insufficient for me to understand what you're trying to say. That issue hasn't been fixed either. |
DHowett
approved these changes
Aug 2, 2024
carlos-zamora
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resize_and_overwritehack into the STL.Writefunctions for xterm's window API.VtIo::Writeris because we used it in a ternary in
CONSOLE_INFORMATION.Ternaries are like if branches with hidden move assignments.
Instead, we simply construct each
Writerin place.No ternary = No move = No problems in life.
The best benefit of this is that this makes calling
GetVtWritera hundred times cheaper.
Otherwise, I still need to extend a few tests in
VtIoTests,but I'm planning to do that later.