Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: switch back to the "latest" OneBranch build image #17630

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Jul 30, 2024

Thanks to a string of compiler bugs, we had to use an older container image that shipped with VS 17.9.

Unfortunately, that container image is falling further and further out of date. The build agents don't cache it any longer, so they spend 30-45 minutes of every build pulling it from the registry.

With the changes to ConPTY in #17510 removing the need for til::bitmap, we no longer need to work around the compiler bugs it exposed.

Furthermore, 17.10.6+ has a much more robust and presumably "working" compiler.

Thanks to a string of compiler bugs, we had to use an older container
image that shipped with VS 17.9.

Unfortunately, that container image is falling further and further out
of date. The build agents don't cache it any longer, so they spend 30-45
minutes of every build pulling it from the registry.

With the changes to ConPTY in #xxxxx removing the need for til::bitmap,
we no longer need to work around the compiler bugs it exposed.

Furthermore, 17.10.6+ has a much more robust and presumably "working"
compiler.
@DHowett
Copy link
Member Author

DHowett commented Jul 30, 2024

Then again, 14.40.33807 still fails for #16595. But that's a different issue.

We can try this in Canary and see how it goes.

@DHowett DHowett changed the title Switch back to the "latest" OneBranch build image build: switch back to the "latest" OneBranch build image Jul 30, 2024
@DHowett DHowett enabled auto-merge (squash) July 30, 2024 18:28
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make build go fast

Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@DHowett DHowett merged commit 39108a7 into main Jul 30, 2024
20 checks passed
@DHowett DHowett deleted the dev/duhowett/nonebranch branch July 30, 2024 23:26
DHowett added a commit that referenced this pull request Jul 31, 2024
DHowett added a commit that referenced this pull request Aug 1, 2024
DHowett added a commit that referenced this pull request Aug 2, 2024
DHowett added a commit that referenced this pull request Aug 2, 2024
@DHowett DHowett modified the milestone: Terminal v1.21 Aug 23, 2024
DHowett added a commit that referenced this pull request Aug 23, 2024
Thanks to a string of compiler bugs, we had to use an older container
image that shipped with VS 17.9.

Unfortunately, that container image is falling further and further out
of date. The build agents don't cache it any longer, so they spend 30-45
minutes of every build pulling it from the registry.

With the changes to ConPTY in #17510 removing the need for til::bitmap,
we no longer need to work around the compiler bugs it exposed.

Furthermore, 17.10.6+ has a much more robust and presumably "working"
compiler.

(cherry picked from commit 39108a7)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgSI7RU
Service-Version: 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants