AtlasEngine: Fix a buffer overrun #17536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
|
If I understand correctly, the source stride is perfectly tuned to be the right size. The destination stride is perfectly tuned for the hardware and the size. How is it possible for us to copy the right amount of data from the source, when the destination stride is shorter, and not corrupt the background bitmap? |
|
The source stride and destination stride are both >= the bitmap width, but that doesn't mean that the destination stride is >= than the source stride. Copying only the bitmap width is the right thing to do and won't corrupt the bitmap. |
DHowett
approved these changes
Jul 9, 2024
carlos-zamora
approved these changes
Jul 9, 2024
DHowett
pushed a commit
that referenced
this pull request
Jul 9, 2024
The strided `memcpy` between buffers failed to account for situations where the destination stride is smaller than the source stride. The solution is to only copy as many bytes as are in each row. ## Validation Steps Performed Even with AppVerifier the issue could not be reproduced. Adding an `assert(srcStride <= mapped.RowPitch)`, however, did trap the bug when WARP is used while BackendD3D is force-enabled. (cherry picked from commit ae8c868) Service-Card-Id: 92972719 Service-Version: 1.20
DHowett
pushed a commit
that referenced
this pull request
Aug 13, 2024
The strided `memcpy` between buffers failed to account for situations where the destination stride is smaller than the source stride. The solution is to only copy as many bytes as are in each row. ## Validation Steps Performed Even with AppVerifier the issue could not be reproduced. Adding an `assert(srcStride <= mapped.RowPitch)`, however, did trap the bug when WARP is used while BackendD3D is force-enabled. (cherry picked from commit ae8c868) Service-Card-Id: 92972720 Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strided
memcpybetween buffers failed to account for situationswhere the destination stride is smaller than the source stride.
The solution is to only copy as many bytes as are in each row.
Validation Steps Performed
Even with AppVerifier the issue could not be reproduced.
Adding an
assert(srcStride <= mapped.RowPitch), however, did trapthe bug when WARP is used while BackendD3D is force-enabled.