Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A minor ConPTY refactoring: Goodbye VtEngine Edition #17510

Merged
merged 69 commits into from
Aug 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
fec6456
A minor ConPTY refactoring: Goodbye VtEngine Edition
lhecker Jul 3, 2024
17d39eb
Fix build, Fix tests
lhecker Jul 3, 2024
656a049
Restore win32im/focus on RIS, Clean up some stuff
lhecker Jul 3, 2024
73e3dd3
Fix support for vim
lhecker Jul 4, 2024
89b4c09
Fix support for far
lhecker Jul 4, 2024
eec17eb
Slightly more elegant formatAttributes
lhecker Jul 4, 2024
db2b762
Remove references to deleted tests
lhecker Jul 4, 2024
9e3d398
Some leftover VtEngine logic
lhecker Jul 4, 2024
8de1a75
Move OVERLAPPED helpers to Types
lhecker Jul 4, 2024
78ae6dd
OVERLAPPED for stdin, Timeouts for PSEUDOCONSOLE_INHERIT_CURSOR
lhecker Jul 4, 2024
7462a20
Fix midi crash, Fix double DSR response
lhecker Jul 4, 2024
7c6c182
Spel
lhecker Jul 4, 2024
3e346f1
Fix synchronous reads
lhecker Jul 5, 2024
c3d5ce1
Fix AuditMode, Unstage some unnecessary changes
lhecker Jul 5, 2024
0e51acd
Fix conhost feature tests
lhecker Jul 5, 2024
6a13e5a
A common C++ L
lhecker Jul 5, 2024
a3f5d59
x86 wants its __stdcall back
lhecker Jul 5, 2024
a138b28
Fix spelling
lhecker Jul 6, 2024
1047ed4
A way simpler ReadConsoleOutputWImplHelper, because why not
lhecker Jul 6, 2024
b78e5bc
Fix x86 build, Fix a missing FMT_COMPILE
lhecker Jul 7, 2024
6b25449
Remove AlwaysAcceptC1
lhecker Jul 7, 2024
d3b4592
Remove IsConsolePty
lhecker Jul 7, 2024
976343e
Fix the cursor reset when entering the ASB twice
lhecker Jul 7, 2024
eaf364e
Fix the injection of ConPTY modes
lhecker Jul 7, 2024
c92c5cf
Fixed cls->RIS translation, Way faster pwsh cls
lhecker Jul 7, 2024
92087fb
AuditMode fix
lhecker Jul 7, 2024
2976661
Remove DECCOLM from DA1
lhecker Jul 7, 2024
9c42bfc
Fix VtIoTests
lhecker Jul 7, 2024
9535e49
Uh...
lhecker Jul 7, 2024
e9e6227
Better GetVtIo naming, Less VtEngine code, Fix control char sanitization
lhecker Jul 7, 2024
edd4c75
Fix GetVtIo for alt buffers
lhecker Jul 7, 2024
c8d0a93
Revert incorrect ASB fix
lhecker Jul 7, 2024
669a530
Don't use RIS for cls
lhecker Jul 7, 2024
7b5b365
Merge remote-tracking branch 'origin/main' into dev/lhecker/goodbye-v…
lhecker Jul 11, 2024
f35127a
Improve comments
lhecker Jul 11, 2024
f0db29d
Fix exception correctness, CRLF translation, C1 pictograms, Line wrap…
lhecker Jul 11, 2024
d65bb80
Forgot to remove LNM
lhecker Jul 11, 2024
8b59551
Forgot to call Submit()
lhecker Jul 11, 2024
512468d
LNM
lhecker Jul 11, 2024
882f3fa
Merge remote-tracking branch 'origin/main' into dev/lhecker/goodbye-v…
lhecker Jul 11, 2024
d3ee58b
Add a missing force-wrap, Minor cleanup
lhecker Jul 11, 2024
cc31a59
Use overlapped pipes for WT
lhecker Jul 12, 2024
495c3e5
10% faster for 128KiB of memory. Good deal.
lhecker Jul 12, 2024
93930bb
They said anonymous overlapped pipes can't be done
lhecker Jul 13, 2024
2c1d7fc
Spell fix
lhecker Jul 13, 2024
e1eb9db
Make AuditMode happy, Improve comments
lhecker Jul 13, 2024
c3f48da
Another one
lhecker Jul 13, 2024
245279d
Eh, NtCreateFile for consistency
lhecker Jul 13, 2024
d67b70d
More flexible CreateOverlappedPipe
lhecker Jul 14, 2024
730d687
VtIo tracing, More robust shutdown
lhecker Jul 14, 2024
316b91a
Proper overlapped IO, ITerminalHandoff3
lhecker Jul 14, 2024
119026a
Right, we can't remove those
lhecker Jul 14, 2024
34857bc
should've
lhecker Jul 14, 2024
44a538d
Address AuditMode issues
lhecker Jul 14, 2024
04aa614
More AuditMode fixes
lhecker Jul 14, 2024
f6f81e3
Merge remote-tracking branch 'origin/main' into dev/lhecker/goodbye-v…
lhecker Jul 15, 2024
55f5f34
Merge remote-tracking branch 'origin/main' into dev/lhecker/goodbye-v…
lhecker Jul 17, 2024
e37b10f
Merge remote-tracking branch 'origin/main' into dev/lhecker/goodbye-v…
lhecker Jul 17, 2024
a7158fb
Fix bad merge
lhecker Jul 17, 2024
81f3778
Merge remote-tracking branch 'origin/main' into dev/lhecker/goodbye-v…
lhecker Jul 18, 2024
21b13ca
Avoid emitting VT for no-op SetConsoleActiveScreenBuffer calls
lhecker Jul 18, 2024
3eb298d
Merge remote-tracking branch 'origin/main' into dev/lhecker/goodbye-v…
lhecker Jul 19, 2024
784f3f8
Bad merge?
lhecker Jul 20, 2024
ce69ee4
Merge remote-tracking branch 'origin/main' into dev/lhecker/goodbye-v…
lhecker Jul 23, 2024
975d258
Revert a few unnecessary changes
lhecker Jul 23, 2024
1421736
Revert another pointless change
lhecker Jul 23, 2024
a8104aa
Thread safety, Fix overlapped write event, Fix shutdown log
lhecker Jul 23, 2024
66d7c4b
Merge remote-tracking branch 'origin/main' into dev/lhecker/goodbye-v…
lhecker Jul 29, 2024
c87bbed
Address feedback
lhecker Jul 30, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/actions/spelling/allow/apis.txt
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ GETTEXTLENGTH
Hashtable
HIGHCONTRASTON
HIGHCONTRASTW
hinternet
HIGHQUALITYSCALE
hinternet
HINTERNET
hotkeys
href
Expand Down Expand Up @@ -155,6 +155,7 @@ NOTIFYBYPOS
NOTIFYICON
NOTIFYICONDATA
ntprivapi
NTSYSCALLAPI
numr
oaidl
ocidl
Expand Down
7 changes: 0 additions & 7 deletions .github/actions/spelling/expect/alphabet.txt
Original file line number Diff line number Diff line change
@@ -1,20 +1,15 @@
AAAAA
AAAAAAAAAAAAA
AAAAAABBBBBBCCC
AAAAABBBBBBCCC
abcd
abcd
ABCDEFGHIJ
abcdefghijk
ABCDEFGHIJKLMNO
abcdefghijklmnop
ABCDEFGHIJKLMNOPQRS
ABCDEFGHIJKLMNOPQRST
ABCG
ABE
abf
BBBBB
BBBBBBBB
BBBBBCCC
BBBBCCCCC
BBGGRR
Expand All @@ -29,10 +24,8 @@ QQQQQQQQQQABCDEFGHIJKLMNOPQRSTQQQQQQQQQ
QQQQQQQQQQABCDEFGHIJKLMNOPQRSTQQQQQQQQQQ
QQQQQQQQQQABCDEFGHIJPQRST
QQQQQQQQQQABCDEFGHIJPQRSTQQQQQQQQQQ
qrstuvwxyz
qwerty
qwertyuiopasdfg
YYYYYYYDDDDDDDDDDD
ZAAZZ
ZABBZ
ZBAZZ
Expand Down
25 changes: 7 additions & 18 deletions .github/actions/spelling/expect/expect.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ ADDALIAS
ADDREF
ADDSTRING
ADDTOOL
AFew
AFill
AFX
AHelper
Expand Down Expand Up @@ -66,7 +65,6 @@ ARRAYSIZE
ARROWKEYS
asan
ASBSET
asdfghjkl
ASetting
ASingle
ASYNCDONTCARE
Expand Down Expand Up @@ -125,6 +123,7 @@ BKCOLOR
BKGND
Bksp
Blt
blu
BLUESCROLL
bmi
BODGY
Expand All @@ -145,7 +144,6 @@ buffersize
buflen
buildtransitive
buildsystems
burriter
BValue
bytebuffer
cac
Expand Down Expand Up @@ -210,7 +208,6 @@ cmw
CNL
cnn
Codeflow
codenav
codepages
codepath
coinit
Expand Down Expand Up @@ -362,6 +359,7 @@ DBGFONTS
DBGOUTPUT
dbh
dblclk
Dcd
DColor
DCOLORVALUE
dcommon
Expand All @@ -379,7 +377,7 @@ DECALN
DECANM
DECARM
DECAUPSS
DECAWM
decawm
DECBI
DECBKM
DECCARA
Expand Down Expand Up @@ -421,6 +419,7 @@ DECPCCM
DECPCTERM
DECPS
DECRARA
decrc
DECRC
DECREQTPARM
DECRLM
Expand All @@ -436,6 +435,7 @@ DECRSPS
decrst
DECSACE
DECSASD
decsc
DECSC
DECSCA
DECSCNM
Expand Down Expand Up @@ -475,7 +475,6 @@ DEFPUSHBUTTON
defterm
DELAYLOAD
DELETEONRELEASE
Delt
depersist
deprioritized
deserializers
Expand Down Expand Up @@ -556,7 +555,6 @@ Efast
efghijklmn
EHsc
EINS
EJO
ELEMENTNOTAVAILABLE
EMPTYBOX
enabledelayedexpansion
Expand Down Expand Up @@ -626,7 +624,6 @@ FINDDOWN
FINDREGEX
FINDSTRINGEXACT
FINDUP
FIter
FITZPATRICK
FIXEDFILEINFO
Flg
Expand Down Expand Up @@ -723,6 +720,7 @@ GETWHEELSCROLLLINES
Gfun
gfx
GGI
GHgh
GHIJK
GHIJKL
gitcheckin
Expand Down Expand Up @@ -948,7 +946,6 @@ LCONTROL
LCTRL
lcx
LEFTALIGN
libpopcnt
libsancov
libtickit
licate
Expand Down Expand Up @@ -1046,7 +1043,6 @@ MAPBITMAP
MAPVIRTUALKEY
MAPVK
MAXDIMENSTRING
maxing
MAXSHORT
maxval
maxversiontested
Expand Down Expand Up @@ -1504,7 +1500,6 @@ REGSTR
RELBINPATH
remoting
renamer
renderengine
rendersize
reparented
reparenting
Expand Down Expand Up @@ -1844,7 +1839,6 @@ Trd
TREX
triaged
triaging
Tribool
TRIMZEROHEADINGS
trx
tsa
Expand Down Expand Up @@ -1938,7 +1932,6 @@ uxtheme
Vanara
vararg
vclib
vcprintf
vcxitems
vectorize
VERCTRL
Expand Down Expand Up @@ -1982,7 +1975,6 @@ vtio
vtmode
vtpipeterm
vtpt
vtrenderer
VTRGB
VTRGBTo
vtseq
Expand All @@ -2004,6 +1996,7 @@ wcswidth
wddm
wddmcon
WDDMCONSOLECONTEXT
WDK
wdm
webpage
websites
Expand Down Expand Up @@ -2071,7 +2064,6 @@ Winperf
WInplace
winres
winrt
wintelnet
winternl
winuser
winuserp
Expand Down Expand Up @@ -2172,7 +2164,6 @@ XTWINOPS
xunit
xutr
XVIRTUALSCREEN
XWalk
yact
YCast
YCENTER
Expand All @@ -2181,14 +2172,12 @@ YLimit
YPan
YSubstantial
YVIRTUALSCREEN
YWalk
Zab
zabcd
Zabcdefghijklmn
Zabcdefghijklmnopqrstuvwxyz
ZCmd
ZCtrl
ZWJs
zxcvbnm
ZYXWVU
ZYXWVUTd
65 changes: 0 additions & 65 deletions NOTICE.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,71 +84,6 @@ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
```

## kimwalisch/libpopcnt

**Source**: [https://github.com/kimwalisch/libpopcnt](https://github.com/kimwalisch/libpopcnt)

### License

```
BSD 2-Clause License

Copyright (c) 2016 - 2019, Kim Walisch
Copyright (c) 2016 - 2019, Wojciech Muła

All rights reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:

1. Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
```

## dynamic_bitset

**Source**: [https://github.com/pinam45/dynamic_bitset](https://github.com/pinam45/dynamic_bitset)

### License

```
MIT License

Copyright (c) 2019 Maxime Pinard

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
```

## \{fmt\}

**Source**: [https://github.com/fmtlib/fmt](https://github.com/fmtlib/fmt)
Expand Down
Loading
Loading