Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update profiles schema to draft 2020-12 #10280

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Update profiles schema to draft 2020-12 #10280

merged 1 commit into from
Jun 4, 2021

Conversation

ealap
Copy link
Contributor

@ealap ealap commented May 30, 2021

Update profiles schema to draft 2020-12 because as mentioned in microsoft/vscode#98724 (comment), OpenAPI Specification 3.1 defines using JSON Schema 2020-12 and VS Code already has early implementation around it.

Basically, this just gets rid of the following error shown by VS Code when editing the settings.json file

Draft 2019-09 schemas are not yet fully supported.

PR Checklist

  • CLA signed. If not, go over here and sign the CLA
  • Schema updated.

@KalleOlaviNiemitalo
Copy link

How does this affect editing the JSON in Visual Studio (not Visual Studio Code)?

@ealap
Copy link
Contributor Author

ealap commented Jun 3, 2021

It seems Visual Studio only has support for version until Draft-04!
https://developercommunity.visualstudio.com/t/support-json-schema-draft-06-draft-07/796216

Hence, intellisense is not working at all with 2019-09, 2020-12.

@DHowett
Copy link
Member

DHowett commented Jun 3, 2021

Sorry for the delay in reviewing this! Much of the team is unavailable this week, so we're short-staffed. We'll get to the backlog of issues and PRs as soon as possible.

@carlos-zamora
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants