overwritting text #18081
Assignees
Labels
Area-VT
Virtual Terminal sequence support
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Product-Conpty
For console issues specifically related to conpty
Milestone
Comments
phr34k
added
Issue-Bug
|
@lhecker I'm putting this one on you to look at. Looks like there's something weird with openssh 9.5 and the new conpty |
zadjii-msft
added
the
Product-Conpty
|
Related to #18004 |
carlos-zamora
added
Area-VT
carlos-zamora
pushed a commit
that referenced
this issue
Jan 27, 2025
) As explained in the comment on `_getViewportCursorPosition`, printing to stdout after initiating a cooked stdin reads is a race condition between the application and the terminal. But we can significantly reduce the likelihood of this being obvious with this change. Related to #18265 Possibly related to #18081 ## Validation Steps Performed Execute the following Go code and start typing: ```go package main import ( "fmt" "time" ) func main() { go func() { time.Sleep(50 * time.Millisecond) fmt.Printf("Here is a prompt! >") }() var text string fmt.Scanln(&text) } ``` Without this change the prompt will disappear, and with this change in place, it'll work as expected. ✅
DHowett
pushed a commit
that referenced
this issue
Jan 28, 2025
) As explained in the comment on `_getViewportCursorPosition`, printing to stdout after initiating a cooked stdin reads is a race condition between the application and the terminal. But we can significantly reduce the likelihood of this being obvious with this change. Related to #18265 Possibly related to #18081 ## Validation Steps Performed Execute the following Go code and start typing: ```go package main import ( "fmt" "time" ) func main() { go func() { time.Sleep(50 * time.Millisecond) fmt.Printf("Here is a prompt! >") }() var text string fmt.Scanln(&text) } ``` Without this change the prompt will disappear, and with this change in place, it'll work as expected. ✅ (cherry picked from commit 1040035) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgWppag Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Windows Terminal version
1.22.2912.0
Windows build number
10.0.22631.0
Other Software
OpenSSH_for_Windows_9.5p1
Steps to reproduce
You can repoduce this bug by opening an the preview version of Windows Terminal. I usually have default profile for pwsh, and once inside of terminal open up an ssh session to a remote windows computer with sshd configured. With the preview version of Windows Terminal, when you type something inside of the ssh session overwrites the text over the current folder i.e.
PS C:\Users\Somebody. When switching back to the non-preview version of Windows Terminal and repeating the same steps everything works normally.Expected Behavior
I expect the terminal not to overwrite to behave in a way it doesn't overwrite current folder i.e.
PS C:\Users\Somebodypart. Presently, it makes it really hard to execute any commands, especially because pwsh also doesn't support clearing the console buffer (some error about invalid cursor handle, I think this implies it's not using vt escape sequences or terminal is not translating these commands).Actual Behavior
When you ssd into an windows machine and for example when you type the clear command, it displays on the screen as
clear\Users\Somebody>. It doesn't matter what environment you sshd into cmd, powershell, pwsh all had the same problems of overwriting.The text was updated successfully, but these errors were encountered: