Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable a background image on top of an acrylic brush #1075

Closed
SJang1 opened this issue May 31, 2019 · 10 comments · Fixed by #1107
Closed

Enable a background image on top of an acrylic brush #1075

SJang1 opened this issue May 31, 2019 · 10 comments · Fixed by #1107
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@SJang1
Copy link

SJang1 commented May 31, 2019

Environment

Windows build number: Microsoft Windows [Version 10.0.18908.1000]
Windows Terminal version (if applicable): commit id d24d647 and 71e19cd tested.

Steps to reproduce

add "backgroundImage" to profiles.

Expected behavior

Backgroung Image changes to what I have selected.

Actual behavior

Only Powershell works as expected, cmd, ubuntu, ... doesn't work like image I've pasted. (Just stays as normal)
image

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 31, 2019
@SJang1 SJang1 changed the title Backgroung Image only works at powershell Background Image only works at powershell May 31, 2019
@Summon528
Copy link
Contributor

The current implementation of background image requires you to disable acrylic

@mdtauk
Copy link

mdtauk commented May 31, 2019

When a background image is set, the acrylic should not be disabled. Instead the acrylic brush should change from a backdrop host one, to an in app one. This will then blur the background image and not show what is behind the window

@Summon528
Copy link
Contributor

When a background image is set, the acrylic should not be disabled. Instead the acrylic brush should change from a backdrop host one, to an in app one. This will then blur the background image and not show what is behind the window

Yeah that is the ideal solution. However this is an unimplemented feature, rather than a bug for now. Core dev did mention to file a follow-up issue for this feature #853 (review) but apparently that has not been done yet

@zadjii-msft
Copy link
Member

Congratulations, this is now that follow-up

@zadjii-msft zadjii-msft changed the title Background Image only works at powershell Enable an acrylic brush on top of a background image May 31, 2019
@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels May 31, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 31, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone May 31, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 3, 2019
@DHowett-MSFT
Copy link
Contributor

Thought: to make this a little better, we might want to implement something like "background stacks" -- so you can specify:

background: [
  { ... acrylic host backdrop ... }
  { ... image tux.exe ... }
  { ... acrylic app-backdrop ... }
]

Marking this as Issue-Feature?

@DHowett-MSFT DHowett-MSFT added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. and removed Issue-Task It's a feature request, but it doesn't really need a major design. labels Jun 3, 2019
@isaacrlevin
Copy link

If I am following this, the following experience is not supported.

  • Image with transparent background over a solid background

I have tried a few combinations of settings to no avail

@DHowett-MSFT
Copy link
Contributor

Indeed. This will hopefully fix that issue as well.

@DHowett-MSFT DHowett-MSFT changed the title Enable an acrylic brush on top of a background image Enable a background image on top of an acrylic brush Jun 24, 2019
@mdtauk
Copy link

mdtauk commented Jun 24, 2019

On top of acrylic, it is more of a watermark. It would also need a placement option.

@Jaykul
Copy link
Contributor

Jaykul commented Jun 26, 2019

We definitely need a placement option

@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. labels Jul 10, 2019
@ghost
Copy link

ghost commented Aug 3, 2019

🎉This issue was addressed in #1107, which has now been successfully released as Windows Terminal Preview v0.3.2142.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants