Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ability (option) to change Acrylic Background Source #10296

Open
Tracked by #9995
SFM61319 opened this issue May 31, 2021 · 1 comment
Open
Tracked by #9995

[FEATURE] Ability (option) to change Acrylic Background Source #10296

SFM61319 opened this issue May 31, 2021 · 1 comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@SFM61319
Copy link

Description of the new feature/enhancement

Ability to change AcrylicBrush.BackgroundSource. It will be really useful when someone wants to set an image background and enable Acrylic over the image (instead of the app background), and hence make a great feature! I personally love AcrylicBrush and have some images that suit acrylic really well, but can't use the Terminal acrylic on those background images since the BackgroundSource is different (AcrylicBrush.BackgroundSource.HostBackdrop, I believe). Adding an option in the settings to change the said background source of the acrylic brush (to lay it over the background image and not the app background/desktop) would be a gamechanger (at least in my humble opinion).

Proposed technical implementation details (optional)

An ability to toggle(?) AcrylicBrush.BackgroundSource between AcrylicBrush.BackgroundSource.Backdrop and AcrylicBrush.BackgroundSource.HostBackdrop (if I remember the valid options/choices correctly) through the Terminal settings.
Just a normal setting (maybe in the Appearance tab?) should be enough. Just two RadioButtons or a ComboBox to choose an acrylic background source. And of course, an "acrylicBackgroundSource" property whose possible values are "backdrop" and "hostBackdrop" (or whatever values you want here, whichever may be more understandable).

Please let me know if you want more details for a better understanding. I'm ready to explain.

Thank you!

@SFM61319 SFM61319 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 31, 2021
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 31, 2021
@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Jun 2, 2021
@zadjii-msft
Copy link
Member

Huh, so this is basically the opposite of #1075. In that issue, we put acrylic unconditionally underneath the image. Now someone actually wants acrylic on top.

I suppose this is a valid request, and one that's possible, but we'll want to make sure the setting is sensible, especially with #10509, and #702

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Jul 6, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 6, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jul 6, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 6, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants