Skip to content

Commit

Permalink
DOC: Fix camelCase (or capitalization) (#10318)
Browse files Browse the repository at this point in the history
Docs have been updated (for bug fixes/features)

docs update => proper capitalisation would be better. 👍: Github

## PR Checklist
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA

### Other information:
Signed-off-by: Ayushman Singh Chauhan <[email protected]>
  • Loading branch information
ayushman17 authored Jun 4, 2021
1 parent 2879fcf commit 1011dce
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ issue id: #1043

## Abstract

This spec is for task #1043 “Be able to set an initial position for the terminal”. It goes over the details of a new feature that allows users to set the initial position and size of the terminal. Expected behavior and design of this feature is included. Besides, future possible follow-up works are also addressed.
This spec is for task #1043 “Be able to set an initial position for the terminal”. It goes over the details of a new feature that allows users to set the initial position and size of the terminal. Expected behavior and design of this feature is included. Besides, future possible follow-up works are also addressed.

## Inspiration

The idea is to allow users to set the initial position of the Terminal when they launch it, prevent the Terminal from appearing on unexpected position (e.g. outside of the screen bounds). We are also going to let users choose to maximize the window when they launch it.

## Solution Design

For now, the Terminal window is put on a default initial position. The program uses CW_USEDEFAULT in the screen coordinates for top-left corner. We have two different types of window – client window and non-client window. However, code path for window creation (WM_CREATE message is shared by the two types of windows) are almost the same for the two types of windows, except that there are some differences in calculation of the width and height of the window.
For now, the Terminal window is put on a default initial position. The program uses CW_USEDEFAULT in the screen coordinates for top-left corner. We have two different types of window – client window and non-client window. However, code path for window creation (WM_CREATE message is shared by the two types of windows) are almost the same for the two types of windows, except that there are some differences in calculation of the width and height of the window.

Two new properties should be added in the json settings file:

Expand Down Expand Up @@ -92,9 +92,9 @@ For now, this feature only allows the user to set initial position and choose wh

3. We may also consider more launch modes. Like full screen mode and minimized mode.

Github issue for future follow-ups: https://github.com/microsoft/terminal/issues/766
GitHub issue for future follow-ups: https://github.com/microsoft/terminal/issues/766

## Resources

Github issue:
GitHub issue:
https://github.com/microsoft/terminal/issues/1043
2 changes: 1 addition & 1 deletion doc/specs/#605 - Search/spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,4 @@ This open issue tracks the phase features of Search: https://github.com/microsof

## Resources

Github Issue: https://github.com/microsoft/terminal/issues/605
GitHub Issue: https://github.com/microsoft/terminal/issues/605

0 comments on commit 1011dce

Please sign in to comment.