Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test migration to MCS SDK (DO NOT MERGE) #1991

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tracyboehrer
Copy link
Member

@tracyboehrer tracyboehrer commented Sep 5, 2024

Not complete:

  1. Custom User-Agent
  2. Connector Request headers
  3. Few unit tests need correction
  4. Unclear how TeamsAttachmentDownloader is created, but it now requires IGetCopilotAccessToken
  5. Removed default constructor for TeamsAdapter. Needs follow up concerning unit tests.
  6. During forking, appear to have trampled a change to FilteredTeamsSSOTokenExchangeMiddleware and OAuthBotAuthentication that happened on main

I don't recommend using this PR. Should likely only take a couple hours to redo when ready + additional testing.

@tracyboehrer tracyboehrer changed the title Test migration to MCS SDK Test migration to MCS SDK (DO NOT MERGE) Sep 5, 2024
@corinagum
Copy link
Collaborator

@tracyboehrer For extra assurance, would you mind turning this PR into a draft PR? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants