Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle multiple templates in case of SQL DB #2354

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

sahuroshan
Copy link
Contributor

In case the assesed instance has more than 50 dbs then instead of one template we will be getting list of templates from the nuget, This PR is to handle that change only.

Added test case for next gen gp recommendation and for mutiple templates case as well.

ADO task link - https://msdata.visualstudio.com/Database%20Systems/_workitems/edit/3100628

Copy link

As part of updating the dependencies in Packages.props we require that any PRs opened also verify that
they've done the following checks.

Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR

  • Built and tested the change locally to validate that the update doesn't cause any regressions and fixes the issues intended
  • Tested changes on all major platforms
    • Windows
    • Linux
    • Mac
  • Check the source repo for any open issues with the release being updated to (if available)

Copy link
Contributor

@Ramudaykumar Ramudaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sahuroshan sahuroshan merged commit e4c6ee6 into main Apr 12, 2024
8 of 10 checks passed
@sahuroshan sahuroshan deleted the roshansahu/armTemplateList branch April 12, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants