Sign KustoServiceLayer files and resource.dlls #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisantia
requested review from
corivera,
alanrenmsft,
Charles-Gagnon and
SakshiS-harma
corivera
approved these changes
Apr 1, 2024
SakshiS-harma
approved these changes
Apr 1, 2024
Charles-Gagnon
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing the pipeline migration, the KustoServiceLayer dlls and exe, as well as the STS resource.dlls, were flagged as not being signed at the end of the pipeline, so this adds them to the list of files that get signed in the current pipeline.
Successful adhoc build: https://mssqltools.visualstudio.com/CrossPlatBuildScripts/_build/results?buildId=223921&view=results