-
Notifications
You must be signed in to change notification settings - Fork 16
Fixing spelling issues within the codebase #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
|
Hey @jsoref, thanks for the contribution. |
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
|
I don't think I have time before my next 🛫 to figure out how to make the linter happy. Personally, I hate linters that don't offer a patch output (since they've already done the work, they might as well show their work to save people like me the effort of setting up the tools). If I can figure out how to make the tool do what I want, I might file an issue + PR for that too. But, I don't expect to have much time for that anytime soon. This run of PRs was done while waiting for |
The formatter check is complaining that two files are not properly formatted. Do run them through clang-format. |
|
The readme has instructions for Windows and Linux. I'm on macOS and the Linux instructions are debian specific and don't detect macOS/not Debian |
Sorry, I don't have access to macOS to add instructions for it.
|
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
|
Thanks for the contribution, @jsoref! |
Related Issues
Why is this change being made?
The misspellings have been reported at https://github.com/jsoref/sfs-client/actions/runs/12292227471#summary-34302447496
What is being changed?
This PR corrects misspellings identified by the check-spelling action (which is an evolution of the script I used ages ago when I first made a PR here...).
How was the change tested?
The action reports that the changes in this PR would make it happy:
https://github.com/jsoref/sfs-client/actions/runs/12292227565#summary-34302447544