.Net: Rename OpenAPI model classes #9595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyMenshykh
had a problem deploying
to
integration
GitHub Actions
Error
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
markwallace-microsoft
approved these changes
Nov 6, 2024
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
rogerbarreto
reviewed
Nov 7, 2024
dotnet/src/Functions/Functions.OpenApi/Serialization/SimpleStyleParameterSerializer.cs
Outdated
Show resolved
Hide resolved
rogerbarreto
approved these changes
Nov 7, 2024
SergeyMenshykh
had a problem deploying
to
integration
GitHub Actions
Error
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
markwallace-microsoft
approved these changes
Nov 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
…9603) ### Motivation, Context and Description The new version, V2, of the [OpenAPI.NET](microsoft/OpenAPI.NET#1906) SDK comes with changes to its model classes. This PR updates the SK OpenAPI model classes to match the SDK's ones. The goal is to reduce breaking changes from the update. Similar changes were done in this PR - [.Net: Rename OpenAPI model classes](#9595) where the `RestApiPayloadProperty.Type`, `RestApiParameter.Type`, and `RestApiParameter.ArrayItemType` were made internal to simplify the update to OpenAPI.NET v2, where their types have been changed. Related task: #6884
…SergeyMenshykh/semantic-kernel into rename-open-api-model-classes-1
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
markwallace-microsoft
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation, Context and Description
The public OpenAPI model classes that have "operation" in their name were renamed to align with the other classes that do not have the word in their name.
Additionally, the
RestApiPayloadProperty.Type,RestApiParameter.Type, andRestApiParameter.ArrayItemTypewere made internal to simplify the update to OpenAPI.NET v2, where their types have been changed.