Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: If no env_file is configured then default to relative .env file #6754

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

moonbox3
Copy link
Contributor

Motivation and Context

We'd like to improve the handling of the .env file related to Pydantic Settings. If Environment variables aren't found, it's possible to fall back on reading the values from a .env file.

Description

Previous to this PR, that is done by specifying the .env file path. Now, if the env_file is not specified, we will default to reading from the relative ".env" file in the cwd.

Contribution Checklist

@moonbox3 moonbox3 requested a review from a team as a code owner June 17, 2024 19:33
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Jun 17, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jun 17, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel
   kernel_pydantic.py21195%51
TOTAL636571889% 

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1511 1 💤 0 ❌ 0 🔥 18.679s ⏱️

@moonbox3 moonbox3 enabled auto-merge June 18, 2024 15:25
@moonbox3 moonbox3 added this pull request to the merge queue Jun 18, 2024
Merged via the queue into microsoft:main with commit e244dad Jun 18, 2024
23 checks passed
@moonbox3 moonbox3 deleted the env_file_default branch June 18, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants