.Net: Fix for RestApiOperation.BuildQueryString #6662
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We have noticed few cases where API calls were failing. Sample response:
"errors":{"since_create_time":["The value '2024-05-01T00:00:00\u002B00:00' is not valid."],"before_create_time":["The value '2024-05-31T23:59:59\u002B00:00' is not valid."]}}
We are passing the value correctly to SK as 2024-05-01T00:00:00+00:00 but then it鈥檚 getting transformed to '2024-05-01T00:00:00\u002B00:00 in this code here.
Then in this particular API these arguments are passed in the URL. The final URL is this: /campaigns?before_create_time=2024-05-31T23%3a59%3a59%5cu002B00%3a00&since_create_time=2024-05-01T00%3a00%3a00%5cu002B00%3a00
Now, I believe the problem is that everything would work just fine if these values were passed as the request payload to the API, where API would deserialize it correctly. But, since these are passed in URL, the value is never deserialized and stays broken.
Description
Contribution Checklist