Python: implement async support for templates #6486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
eavanvalkenburg
force-pushed
the
async_jinja2
branch
from
df8d448
to
4fcb555
Compare
Python 3.10 Test Coverage Report •
Python 3.10 Unit Test Overview
|
juliomenendez
approved these changes
Jun 3, 2024
python/semantic_kernel/prompt_template/utils/template_function_helpers.py
Outdated
Show resolved
Hide resolved
moonbox3
reviewed
Jun 3, 2024
python/semantic_kernel/prompt_template/utils/template_function_helpers.py
Show resolved
Hide resolved
eavanvalkenburg
force-pushed
the
async_jinja2
branch
from
1420499
to
c71f9c9
Compare
moonbox3
approved these changes
Jun 3, 2024
moonbox3
approved these changes
Jun 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
eavanvalkenburg
force-pushed
the
async_jinja2
branch
from
5fa1f78
to
8fd8476
Compare
eavanvalkenburg
force-pushed
the
async_jinja2
branch
from
8fd8476
to
26a238b
Compare
juliomenendez
approved these changes
Jun 3, 2024
moonbox3
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jinja2 templates now use async functions instead of nested ones!
With full testing
Description
Contribution Checklist