Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Python: Docs: Fix broken link #6092

Merged
merged 12 commits into from
May 2, 2024
Merged

Java: Python: Docs: Fix broken link #6092

merged 12 commits into from
May 2, 2024

Conversation

crickman
Copy link
Contributor

@crickman crickman commented May 2, 2024

Motivation and Context

https://openai.com/product is failing Check .md links workflow.

Description

Revise links.

https://github.com/microsoft/semantic-kernel/actions/workflows/markdown-link-check.yml

Whitespace edits peformed by VS Code

Contribution Checklist

@crickman crickman requested review from a team as code owners May 2, 2024 00:54
@crickman crickman self-assigned this May 2, 2024
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel kernel Issues or pull requests impacting the core kernel java Issue or PR regarding Java code documentation labels May 2, 2024
@crickman crickman added bug Something isn't working PR: in progress Under development and/or addressing feedback and removed .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel kernel Issues or pull requests impacting the core kernel java Issue or PR regarding Java code labels May 2, 2024
@github-actions github-actions bot changed the title Fix broken link Python: Fix broken link May 2, 2024
@github-actions github-actions bot changed the title Python: Fix broken link .Net: Fix broken link May 2, 2024
@github-actions github-actions bot changed the title .Net: Fix broken link Java: Fix broken link May 2, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented May 2, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL5838103882% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1257 1 💤 0 ❌ 0 🔥 13.308s ⏱️

@crickman crickman changed the title Java: Fix broken link Docs: Fix broken link May 2, 2024
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel kernel Issues or pull requests impacting the core kernel java Issue or PR regarding Java code labels May 2, 2024
@github-actions github-actions bot changed the title Docs: Fix broken link Java: Docs: Fix broken link May 2, 2024
@github-actions github-actions bot changed the title Java: Docs: Fix broken link .Net: Docs: Fix broken link May 2, 2024
@github-actions github-actions bot changed the title .Net: Docs: Fix broken link Python: Docs: Fix broken link May 2, 2024
@crickman crickman removed the java Issue or PR regarding Java code label May 2, 2024
@crickman crickman closed this May 2, 2024
@crickman crickman reopened this May 2, 2024
@markwallace-microsoft markwallace-microsoft added the java Issue or PR regarding Java code label May 2, 2024
@github-actions github-actions bot changed the title Python: Docs: Fix broken link Java: Python: Docs: Fix broken link May 2, 2024
@crickman crickman requested a review from dmytrostruk May 2, 2024 02:29
@crickman crickman added PR: ready for review All feedback addressed, ready for reviews and removed PR: in progress Under development and/or addressing feedback labels May 2, 2024
@dmytrostruk dmytrostruk merged commit ac6e03b into main May 2, 2024
31 of 34 checks passed
@dmytrostruk dmytrostruk deleted the fix_openai_link branch May 2, 2024 02:55
@dmytrostruk
Copy link
Member

Bypassed branch protection and merged it to unblock other PRs.

johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
`https://openai.com/product` is failing `Check .md links` workflow.

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

Revise links.


https://github.com/microsoft/semantic-kernel/actions/workflows/markdown-link-check.yml

Whitespace edits peformed by VS Code

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
johnoliver pushed a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
`https://openai.com/product` is failing `Check .md links` workflow.

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

Revise links.


https://github.com/microsoft/semantic-kernel/actions/workflows/markdown-link-check.yml

Whitespace edits peformed by VS Code

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation java Issue or PR regarding Java code kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews python Pull requests for the Python Semantic Kernel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants