-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: planner love #5477
Merged
eavanvalkenburg
merged 4 commits into
microsoft:main
from
eavanvalkenburg:basic_planner_fix
Mar 14, 2024
Merged
Python: planner love #5477
eavanvalkenburg
merged 4 commits into
microsoft:main
from
eavanvalkenburg:basic_planner_fix
Mar 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
python
Pull requests for the Python Semantic Kernel
samples
labels
Mar 14, 2024
Python 3.8 Test Coverage Report •
Python 3.8 Unit Test Overview
|
moonbox3
requested changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, a few small comments.
python/semantic_kernel/planners/sequential_planner/sequential_planner.py
Outdated
Show resolved
Hide resolved
moonbox3
approved these changes
Mar 14, 2024
eavanvalkenburg
force-pushed
the
basic_planner_fix
branch
from
March 14, 2024 14:14
ea8f0d3
to
82297ab
Compare
juliomenendez
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup! LGTM
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Based on microsoft#5474 went into the `using-the-planner` notebook and made sure it works with the latest code. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Moved all the planners to use '-' in line with the current work on new templates and planners, once that is in several extension classes can be changed. Encountered several small bugs left over from changes over the last months. Got through the whole notebook with results. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Based on #5474 went into the
using-the-planner
notebook and made sure it works with the latest code.Description
Moved all the planners to use '-' in line with the current work on new templates and planners, once that is in several extension classes can be changed.
Encountered several small bugs left over from changes over the last months.
Got through the whole notebook with results.
Contribution Checklist