Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net Hugging Face HttpClient Connector Update #5075

Merged
merged 52 commits into from
Feb 23, 2024
Merged

.Net Hugging Face HttpClient Connector Update #5075

merged 52 commits into from
Feb 23, 2024

Conversation

RogerBarreto
Copy link
Member

@RogerBarreto RogerBarreto commented Feb 19, 2024 •
edited
Loading

Motivation and Context

Resolves Partially #4947

Update Hugging Face connector segregating the responsibilities of the TextGenerationService, TextEmbeddingService, HttpClient, JsonParsing, EndPointResolving.

Description

This enables paving the way to support additional Hugging Face modalities

@RogerBarreto
Preparing 1.1 release
3dd55f4
@RogerBarreto
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
8de6748
@RogerBarreto
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
5bbd7fc
@RogerBarreto
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
f8a5bcb
@RogerBarreto
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
80ea9b0
@RogerBarreto
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
e53fbf7
@RogerBarreto
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
4cfba8f
@RogerBarreto
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
8075acf
@RogerBarreto
Adding hugging face httpclient
d5c4e6a
@RogerBarreto
Decimal to Double
ff1fc3c
@RogerBarreto
Streaming object model
6b83649
@RogerBarreto
Merge branch 'main' of https://github.com/microsoft/semantic-kernel i…
b22bfbc 
…nto features/hugging-face-httpclient
@RogerBarreto
Correct naming
9bc339d
@RogerBarreto RogerBarreto requested a review from a team as a code owner February 19, 2024 14:31
@RogerBarreto RogerBarreto self-assigned this Feb 19, 2024
@shawncal shawncal added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Feb 19, 2024
Krzysztof318
Krzysztof318 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@Krzysztof318 Krzysztof318 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a small suggestion for passing modelId

dotnet/src/Connectors/Connectors.HuggingFace/Core/HuggingFaceClient.cs Outdated Show resolved Hide resolved
dotnet/src/Connectors/Connectors.HuggingFace/Core/HuggingFaceClient.cs Outdated Show resolved Hide resolved
@RogerBarreto
Copy link
Member Author

RogerBarreto commented Feb 22, 2024 •
edited
Loading

You need so big test data file embeddings_test_response_feature_extraction.json?

@Krzysztof318 Good point, didnt realize it was so big, updated to a smaller sample.

@RogerBarreto RogerBarreto linked an issue Feb 22, 2024 that may be closed by this pull request
.Net: Update Hugging Face connector #4947
Closed
@RogerBarreto RogerBarreto added this pull request to the merge queue Feb 23, 2024
Merged via the queue into microsoft:main with commit 316ff5d Feb 23, 2024
18 checks passed
@RogerBarreto RogerBarreto deleted the features/hugging-face-httpclient branch February 23, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub left review comments

@Krzysztof318 Krzysztof318 Krzysztof318 approved these changes

@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

@markwallace-microsoft markwallace-microsoft markwallace-microsoft approved these changes

Assignees

@RogerBarreto RogerBarreto

Labels
documentation kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.Net: Update Hugging Face connector
6 participants
@RogerBarreto @Krzysztof318 @stephentoub @SergeyMenshykh @markwallace-microsoft @shawncal