-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing logic in custom or
HB helper
#4804
Merged
teresaqhoang
merged 10 commits into
microsoft:main
from
teresaqhoang:custom-helper-logic-bug
Feb 1, 2024
Merged
Fixing logic in custom or
HB helper
#4804
teresaqhoang
merged 10 commits into
microsoft:main
from
teresaqhoang:custom-helper-logic-bug
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teresaqhoang
added
bug
Something isn't working
planner
Anything related to planner or plans
labels
Jan 31, 2024
shawncal
added
.NET
Issue or Pull requests regarding .NET code
kernel
Issues or pull requests impacting the core kernel
labels
Jan 31, 2024
github-actions
bot
changed the title
Fixing logic in custom or HB helper
.Net: Fixing logic in custom or HB helper
Jan 31, 2024
teresaqhoang
changed the title
.Net: Fixing logic in custom or HB helper
Fixing logic in custom Jan 31, 2024
or
HB helper
gitri-ms
reviewed
Jan 31, 2024
dotnet/src/Extensions/PromptTemplates.Handlebars/Helpers/KernelHelpers/KernelSystemHelpers.cs
Show resolved
Hide resolved
…oang/semantic-kernel into custom-helper-logic-bug
dmytrostruk
approved these changes
Feb 1, 2024
This was
linked to
issues
Feb 1, 2024
gitri-ms
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The custom
or
helper had a bug where it was checking for null values, rather than checking for non-null values. This PR changes the condition tonot null
.Also, renamed a heading in the CreatePlan prompt to better guide the model in identifying Handlebars built-in block helpers.
Description
Additional changes to the
GetArgumentValue
method inKernelHelperUtils.cs
to return null if variable isn't defined.Before, if the template referenced a variable that wasn't defined in
KernelArguments
, the method would just return the key as a string. Now, it just returns null (as expected).Should resolve these issues:
Contribution Checklist