Java: Fix linting issues #4800
Merged
Java: Fix linting issues #4800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsgrieve
requested changes
Jan 31, 2024
...java/com/microsoft/semantickernel/aiservices/openai/chatcompletion/OpenAIChatCompletion.java
Outdated
Show resolved
Hide resolved
| @@ -105,6 +105,6 @@ Is it weekend time (weekend/not weekend)? | |||
| // Show the result | |||
| System.out.println("--- Prompt Function result"); | |||
| var result = kernel.invokeAsync(kindOfDay, null, String.class).block(); | |||
| System.out.println(result.getResultVariable()); | |||
| System.out.println(result.getResultVariable().getValue()); | |||
There was a problem hiding this comment.
I thought there was a "getValue()" on FunctionResult that is a shorthand for this.
<edit>I see you do this in Example09. Best to be consistent. It doesn't matter to me which way.</edit>
...c/main/java/com/microsoft/semantickernel/samples/syntaxexamples/Example09_FunctionTypes.java
Show resolved
Hide resolved
...c/main/java/com/microsoft/semantickernel/samples/syntaxexamples/Example09_FunctionTypes.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/microsoft/semantickernel/samples/syntaxexamples/Example09_FunctionTypes.java
Show resolved
Hide resolved
| return of(t); | ||
| } | ||
|
|
||
| public static <T> ContextVariable<T> untypedOf( |
There was a problem hiding this comment.
Should this return ContextVariable<?>
...c/main/java/com/microsoft/semantickernel/orchestration/contextvariables/ContextVariable.java
Show resolved
Hide resolved
dsgrieve
approved these changes
Jan 31, 2024
This was referenced Feb 8, 2024
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
Fix linting issues
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
Fix linting issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Contribution Checklist