-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net Ollama Connector [WIP] #4789
.Net Ollama Connector [WIP] #4789
Conversation
Nice to look at this code 😄 |
I'd be happy to contribute to this connector. Let me know if there is anything I can help with. Currently, I don't see embedding support, I can take a look over that |
https://ollama.ai/blog/openai-compatibility Ollama just released OpenAI compatibility endpoints so it may be possible to use the existing OpenAI connector with Ollama |
@BLaZeKiLL interesting, so example with LM-studio #4753 should also works with ollama |
@BLaZeKiLL Thanks for being supportive and wishing to help on this feature. I made the latest changes to support the existing API and definitely would appreciate further changes to it to support embeddings, model change, and add the missing UnitTests to it. Most of the code is very close to the pattern @Krzysztof318 used in Gemini one, which is a good pattern. Suggest using/re-using some if his already made UT to cover the code in this PR if you can. I will need to work on other connectors for the next week, feel free to jump in and push further changes from my latest commit moving forward. I will be happy to look into it. |
I'd be happy to take this forward. I'll start with embedding support. |
3a9d06a
into
microsoft:feature-connectors-ollama
<!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Motivation and Context
Description
Contribution Checklist