Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net Ollama Connector [WIP] #4789

Conversation

RogerBarreto
Copy link
Member

Motivation and Context

Description

Contribution Checklist

@RogerBarreto RogerBarreto requested a review from a team as a code owner January 30, 2024 18:27
@shawncal shawncal added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Jan 30, 2024
@Krzysztof318
Copy link
Contributor

Nice to look at this code 😄

@BLaZeKiLL
Copy link

I'd be happy to contribute to this connector. Let me know if there is anything I can help with.

Currently, I don't see embedding support, I can take a look over that

@BLaZeKiLL
Copy link

https://ollama.ai/blog/openai-compatibility

Ollama just released OpenAI compatibility endpoints so it may be possible to use the existing OpenAI connector with Ollama

@Krzysztof318
Copy link
Contributor

@BLaZeKiLL interesting, so example with LM-studio #4753 should also works with ollama

@RogerBarreto
Copy link
Member Author

RogerBarreto commented Feb 15, 2024

@BLaZeKiLL Thanks for being supportive and wishing to help on this feature. I made the latest changes to support the existing API and definitely would appreciate further changes to it to support embeddings, model change, and add the missing UnitTests to it.

Most of the code is very close to the pattern @Krzysztof318 used in Gemini one, which is a good pattern. Suggest using/re-using some if his already made UT to cover the code in this PR if you can.

I will need to work on other connectors for the next week, feel free to jump in and push further changes from my latest commit moving forward.

I will be happy to look into it.

@BLaZeKiLL
Copy link

I'd be happy to take this forward. I'll start with embedding support.

@RogerBarreto RogerBarreto merged commit 3a9d06a into microsoft:feature-connectors-ollama Feb 24, 2024
8 of 13 checks passed
@RogerBarreto RogerBarreto deleted the feature-connectors-ollama branch March 4, 2024 14:24
RogerBarreto added a commit to RogerBarreto/semantic-kernel that referenced this pull request May 29, 2024
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants