-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: ADR for RAG pattern in SK #4771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great write-up, posted some comments/thoughts below.
I agree. There's significant value to having the abstraction, and we'd be doing folks a disservice by getting rid of it even if you can't do everything with it. You can do a lot with it (and we should ensure it's as good / full-featured as possible), including bootstrapping / getting up and running, and in a way that lets you postpone choice, i.e. you can write code without committing to a specific db, you can experiment, you can get your feet under you, and then if you later find you need to go beyond what the abstraction offers, you can break glass and use direct functionality on a specific db you commit to at that point. |
Co-authored-by: Shay Rojansky <[email protected]>
@roji @stephentoub Thank you for feedback, it's very helpful! We will take it into account when deciding on next steps. |
Resolves: microsoft#4578 Resolves: microsoft#3455 1. Added ADR which describes different approaches how to use RAG pattern in current version of Semantic Kernel and a couple of new possible approaches, which could be added in the future. 2. Added examples how to use RAG pattern with ChatGPT Retrieval Plugin, TextMemoryPlugin and custom plugin. 3. Small fixes to TextMemoryPlugin. --------- Co-authored-by: Shay Rojansky <[email protected]>
Resolves: #4578
Resolves: #3455