Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: ADR for Automatic Tool Calling Controls #4686

Closed
wants to merge 6 commits into from

Conversation

gitri-ms
Copy link
Contributor

@gitri-ms gitri-ms commented Jan 19, 2024

Motivation and Context

ADR proposing additional controls for automatic tool calling

Task 4300 is underway to use automatic tool calling in the FunctionCallingStepwisePlanner. This will allow for more robust and consistent handling of tool calls and minimize duplication of code.

Currently, as part of the planner configuration, the caller can set the MaxIterations field to limit the number of steps (and therefore, calls to the model) utilized by the planner. This enables the caller to control things such as cost, time, etc., spent by the planner.

The current implementation of automatic tool calling allows for multiple consecutive tool calls to be requested/invoked by the model for a single request. However, the limit on how many consecutive tool calls can be performed per request is not exposed to the caller. Therefore, the caller cannot control or even measure after the fact how many model roundtrips occur for a single request. This control is necessary for the planner to accurately enforce the MaxIterations limit.

Code snippets are provided in the ADR, but you can see the full changes in #4687 (options 1 & 2) and #4688 (option 3)

@gitri-ms gitri-ms marked this pull request as draft January 31, 2024 20:45
@gitri-ms gitri-ms added the PR: in progress Under development and/or addressing feedback label Jan 31, 2024
@gitri-ms gitri-ms marked this pull request as ready for review February 15, 2024 21:59
@gitri-ms gitri-ms added PR: ready for review All feedback addressed, ready for reviews and removed PR: in progress Under development and/or addressing feedback labels Feb 15, 2024
@gitri-ms gitri-ms mentioned this pull request Feb 16, 2024
4 tasks
@crickman crickman assigned crickman and unassigned gitri-ms Mar 11, 2024
@crickman crickman added .NET Issue or Pull requests regarding .NET code planner Anything related to planner or plans labels Mar 11, 2024
@github-actions github-actions bot changed the title ADR for Automatic Tool Calling Controls .Net: ADR for Automatic Tool Calling Controls Mar 11, 2024
@crickman crickman assigned dmytrostruk and unassigned crickman Mar 26, 2024
@crickman
Copy link
Contributor

@dmytrostruk FYI - Historical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation .NET Issue or Pull requests regarding .NET code planner Anything related to planner or plans PR: ready for review All feedback addressed, ready for reviews
Projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants