.Net: Bug: The Milvus connector search metric type is incorrect #7062
Comments
markwallace-microsoft
added
.NET
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 3, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> The `metricType` parameter in the `SearchAsync` method of the Milvus connector is incorrect. It will always use the `SimilarityMetricType.Ip` for searching. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> The current code hard-codes the milvus search metric type to `SimilarityMetricType.Ip`, which causes the issue where even if the Metric type is specified as `SimilarityMetricType.Cosine` when creating the `MilvusMemoryStore`, `SimilarityMetricType.IP` is still used during the search. Issue: [#7062](#7062) ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: Roger Barreto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The
metricTypeparameter in theSearchAsyncmethod of the Milvus connector is incorrect.The current code hard-codes the milvus search metric type to
SimilarityMetricType.Ip, which causes the issue where even if the Metric type is specified asSimilarityMetricType.Cosinewhen creating theMilvusMemoryStore,SimilarityMetricType.IPis still used during the search.To Reproduce
The source code:
semantic-kernel/dotnet/src/Connectors/Connectors.Memory.Milvus
/MilvusMemoryStore.cs#L449
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
Platform
/MilvusMemoryStore.cs#L449
The text was updated successfully, but these errors were encountered: