Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Provide mechanism to allow HttpRequestMessage for Open API calls to be modified using KernelFunctionMetadata #6734

Closed
markwallace-microsoft opened this issue Jun 17, 2024 · 0 comments · Fixed by #6755
Assignees
Labels
filters Anything related to filters kernel.core

Comments

@markwallace-microsoft
Copy link
Member

We need a mechanism to allow the HttpRequestMessage used for an Open API call to be modified e.g. additional headers or query parameters to be added by the client application using data that comes from the KernelFunctionMetadata.

We allow additional properties to be added to the KernelFunctionMetadata and these can be used to represent additional HTTP headers that must be included in the REST request. The client application needs a way to provide these and will need access to the KernelFunction and the HttpRequestMessage to do so.

@markwallace-microsoft markwallace-microsoft added kernel.core filters Anything related to filters triage and removed triage labels Jun 17, 2024
@markwallace-microsoft markwallace-microsoft changed the title Provide mechanism to allow HttpRequestMessage for Open API calls to be modified .Net: Provide mechanism to allow HttpRequestMessage for Open API calls to be modified Jun 17, 2024
@markwallace-microsoft markwallace-microsoft self-assigned this Jun 17, 2024
@markwallace-microsoft markwallace-microsoft changed the title .Net: Provide mechanism to allow HttpRequestMessage for Open API calls to be modified .Net: Provide mechanism to allow HttpRequestMessage for Open API calls to be modified using KernelFunctionMetadata Jun 17, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 19, 2024
…s to be modified using KernelFunctionMetadata (#6755)

### Motivation and Context

Closes #6734 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Dmytro Struk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filters Anything related to filters kernel.core
Projects
Archived in project
1 participant