Skip to content

Commit

Permalink
Misc code style fixes (#903)
Browse files Browse the repository at this point in the history
Co-authored-by: Adrian Bonar <[email protected]>
  • Loading branch information
dluc and adrianwyatt committed May 10, 2023
1 parent 6afcbe2 commit 119ffdd
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 11 deletions.
7 changes: 7 additions & 0 deletions dotnet/SK-dotnet.sln
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Connectors.Memory.AzureCogn
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Skills.Grpc", "src\Skills\Skills.Grpc\Skills.Grpc.csproj", "{E52F805C-794A-4CA9-B684-DFF358B18820}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "InternalUtilities", "InternalUtilities", "{4D3DAE63-41C6-4E1C-A35A-E77BDFC40675}"
ProjectSection(SolutionItems) = preProject
src\InternalUtilities\InternalUtilities.props = src\InternalUtilities\InternalUtilities.props
EndProjectSection
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -246,6 +251,8 @@ Global
{A350933D-F9D5-4AD3-8C4F-B856B5020297} = {078F96B4-09E1-4E0E-B214-F71A4F4BF633}
{EC3BB6D1-2FB2-4702-84C6-F791DE533ED4} = {0247C2C9-86C3-45BA-8873-28B0948EDC0C}
{E52F805C-794A-4CA9-B684-DFF358B18820} = {9ECD1AA0-75B3-4E25-B0B5-9F0945B64974}
{E4B777A1-28E1-41BE-96AE-7F3EC61FD5D4} = {831DDCA2-7D2C-4C31-80DB-6BDB3E1F7AE0}
{4D3DAE63-41C6-4E1C-A35A-E77BDFC40675} = {831DDCA2-7D2C-4C31-80DB-6BDB3E1F7AE0}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {FBDC56A3-86AD-4323-AA0F-201E59123B83}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Licensed to the .NET Foundation under one or more agreements.
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

Expand All @@ -21,4 +21,3 @@ public CallerArgumentExpressionAttribute(string parameterName)
}

#endif

Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ private static void AddSemanticTextMemory(this IServiceCollection services)
{
throw new InvalidOperationException("MemoriesStore type is Qdrant and Qdrant configuration is null.");
}

services.AddSingleton<IMemoryStore>(sp => new QdrantMemoryStore(
config.Qdrant.Host, config.Qdrant.Port, config.Qdrant.VectorSize, sp.GetRequiredService<ILogger<QdrantMemoryStore>>()));
services.AddScoped<ISemanticTextMemory>(sp => new SemanticTextMemory(
Expand All @@ -100,6 +101,7 @@ private static void AddSemanticTextMemory(this IServiceCollection services)
{
throw new InvalidOperationException("MemoriesStore type is AzureCognitiveSearch and AzureCognitiveSearch configuration is null.");
}

services.AddSingleton<ISemanticTextMemory>(sp => new AzureCognitiveSearchMemory(config.AzureCognitiveSearch.Endpoint, config.AzureCognitiveSearch.Key));
break;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public Task<Plan> CreatePlanAsync(string goal)
// No functions are available - return an empty plan.
return Task.FromResult(new Plan(goal));
}

return new ActionPlanner(this.Kernel).CreatePlanAsync(goal);
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Copyright (c) Microsoft. All rights reserved.

using System.Text.Json.Serialization;
using SharpYaml.Tokens;

namespace SemanticKernel.Service.Skills.OpenApiSkills.JiraSkill.Model;

Expand All @@ -19,9 +18,9 @@ public class CommentResponse
/// <summary>
/// Initializes a new instance of the <see cref="CommentResponse"/> class.
/// </summary>
/// <param name="allcomments">List of all comments on the Issue.</param>
public CommentResponse(IEnumerable<IndividualComments> allcomments)
/// <param name="allComments">List of all comments on the Issue.</param>
public CommentResponse(IEnumerable<IndividualComments> allComments)
{
this.AllComments = allcomments;
this.AllComments = allComments;
}
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
// Copyright (c) Microsoft. All rights reserved.

using System.Text.Json.Serialization;
using SemanticKernel.Service.Skills.OpenApiSkills.JiraSkill.Model;

namespace SemanticKernel.Service.Skills.OpenApiSkills;
namespace SemanticKernel.Service.Skills.OpenApiSkills.JiraSkill.Model;

/// <summary>
/// Represents the fields that make up an IssueResponse.
Expand Down Expand Up @@ -37,13 +36,13 @@ public class IssueResponseFields
/// <summary>
/// Initializes a new instance of the <see cref="IssueResponseFields"/> class.
/// </summary>
/// <param name="statuscategorychangedate">The date time the issue was last changed.</param>
/// <param name="statusCategoryChangeDate">The date time the issue was last changed.</param>
/// <param name="summary">The Summary of the issue.</param>
/// <param name="parent">The Parent of the issue.</param>
/// <param name="commentResponse">List of all comments on the issue.</param>
public IssueResponseFields(string statuscategorychangedate, string summary, IssueResponse parent, CommentResponse commentResponse)
public IssueResponseFields(string statusCategoryChangeDate, string summary, IssueResponse parent, CommentResponse commentResponse)
{
this.StatusCategoryChangeDate = statuscategorychangedate;
this.StatusCategoryChangeDate = statusCategoryChangeDate;
this.Summary = summary;
this.Parent = parent;
this.CommentResponse = commentResponse;
Expand Down

0 comments on commit 119ffdd

Please sign in to comment.